-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: add unit tests for stdcm simulation report sheet #7979
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7979 +/- ##
============================================
+ Coverage 28.06% 28.11% +0.05%
Complexity 2081 2081
============================================
Files 1289 1289
Lines 157717 157740 +23
Branches 3116 3131 +15
============================================
+ Hits 44260 44347 +87
+ Misses 111582 111503 -79
- Partials 1875 1890 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
67d5e92
to
18514b6
Compare
18514b6
to
8679e92
Compare
c53e776
to
7a7d407
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR ! Left some comments
front/src/applications/stdcm/utils/__tests__/simulationReportSheet.spec.ts
Outdated
Show resolved
Hide resolved
front/src/applications/stdcm/utils/__tests__/simulationReportSheet.spec.ts
Show resolved
Hide resolved
front/src/applications/stdcm/utils/__tests__/simulationReportSheet.spec.ts
Outdated
Show resolved
Hide resolved
front/src/applications/stdcm/utils/__tests__/simulationReportSheet.spec.ts
Outdated
Show resolved
Hide resolved
20362be
to
6259641
Compare
front/src/applications/stdcm/utils/formatSimulationReportSheet.ts
Outdated
Show resolved
Hide resolved
front/src/applications/stdcm/utils/formatSimulationReportSheet.ts
Outdated
Show resolved
Hide resolved
front/src/applications/stdcm/utils/__tests__/simulationReportSheet.spec.ts
Show resolved
Hide resolved
front/src/applications/stdcm/utils/formatSimulationReportSheet.ts
Outdated
Show resolved
Hide resolved
front/src/applications/stdcm/utils/__tests__/simulationReportSheet.spec.ts
Show resolved
Hide resolved
front/src/applications/stdcm/utils/__tests__/simulationReportSheet.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, good job !
47c5584
to
be414ba
Compare
be414ba
to
98bf082
Compare
closes #7816