Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: add unit tests for stdcm simulation report sheet #7979

Merged
merged 1 commit into from
Jul 18, 2024
Merged

front: add unit tests for stdcm simulation report sheet #7979

merged 1 commit into from
Jul 18, 2024

Conversation

Akctarus
Copy link
Contributor

@Akctarus Akctarus commented Jul 8, 2024

closes #7816

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024 •
edited

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 55.76923% with 23 lines in your changes missing coverage. Please review.

Project coverage is 28.11%. Comparing base (580140d) to head (98bf082).

Files Patch % Lines
...cations/stdcm/utils/formatSimulationReportSheet.ts 80.55% 4 Missing and 3 partials ⚠️
...cations/stdcm/components/SimulationReportSheet.tsx 0.00% 5 Missing ⚠️
...nt/src/applications/stdcm/views/StdcmResultsV2.tsx 0.00% 4 Missing ⚠️
...s/stdcmV2/components/StdcmResults/StdcmResults.tsx 0.00% 4 Missing ⚠️
...tions/stdcm/components/SimulationReportSheetV2.tsx 0.00% 1 Missing ⚠️
...ront/src/applications/stdcm/views/StdcmResults.tsx 0.00% 1 Missing ⚠️
...cmV2/components/StdcmResults/StdcmResultsTable.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #7979      +/-   ##
============================================
+ Coverage     28.06%   28.11%   +0.05%     
  Complexity     2081     2081              
============================================
  Files          1289     1289              
  Lines        157717   157740      +23     
  Branches       3116     3131      +15     
============================================
+ Hits          44260    44347      +87     
+ Misses       111582   111503      -79     
- Partials       1875     1890      +15
Flag Coverage Δ
core 75.11% <ø> (ø)
editoast 70.75% <ø> (-0.05%) ⬇️
front 9.99% <55.76%> (+0.08%) ⬆️
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 73.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus force-pushed the tmn/front/stdcm-simulation-sheet-unit-test branch 3 times, most recently from 67d5e92 to 18514b6 Compare July 8, 2024 15:37
@Akctarus Akctarus marked this pull request as ready for review July 8, 2024 15:40
@Akctarus Akctarus requested a review from a team as a code owner July 8, 2024 15:40
@Akctarus Akctarus marked this pull request as draft July 8, 2024 15:46
@Akctarus Akctarus force-pushed the tmn/front/stdcm-simulation-sheet-unit-test branch from 18514b6 to 8679e92 Compare July 8, 2024 15:48
@Akctarus Akctarus marked this pull request as ready for review July 9, 2024 07:29
@Akctarus Akctarus force-pushed the tmn/front/stdcm-simulation-sheet-unit-test branch 5 times, most recently from c53e776 to 7a7d407 Compare July 15, 2024 12:52
theocrsb
theocrsb approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

SharglutDev
SharglutDev requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR ! Left some comments

front/src/applications/stdcm/utils/__tests__/simulationReportSheet.spec.ts Outdated Show resolved Hide resolved
front/src/applications/stdcm/utils/__tests__/simulationReportSheet.spec.ts Show resolved Hide resolved
front/src/applications/stdcm/utils/__tests__/simulationReportSheet.spec.ts Outdated Show resolved Hide resolved
front/src/applications/stdcm/utils/__tests__/simulationReportSheet.spec.ts Outdated Show resolved Hide resolved
@Akctarus Akctarus force-pushed the tmn/front/stdcm-simulation-sheet-unit-test branch from 20362be to 6259641 Compare July 17, 2024 15:09
SharglutDev
SharglutDev approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job !

@Akctarus Akctarus force-pushed the tmn/front/stdcm-simulation-sheet-unit-test branch from 47c5584 to be414ba Compare July 18, 2024 14:40
@Akctarus Akctarus force-pushed the tmn/front/stdcm-simulation-sheet-unit-test branch from be414ba to 98bf082 Compare July 18, 2024 14:41
@Akctarus Akctarus enabled auto-merge July 18, 2024 14:41
@Akctarus Akctarus added this pull request to the merge queue Jul 18, 2024
Merged via the queue into dev with commit 7dc8897 Jul 18, 2024
20 checks passed
@Akctarus Akctarus deleted the tmn/front/stdcm-simulation-sheet-unit-test branch July 18, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theocrsb theocrsb theocrsb approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for STDCM simulation report sheet
4 participants
@Akctarus @codecov-commenter @theocrsb @SharglutDev