-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performances of batch pathfinding and simulation 🚀 #7995
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7995 +/- ##
============================================
- Coverage 28.07% 28.07% -0.01%
Complexity 2075 2075
============================================
Files 1289 1288 -1
Lines 157734 157708 -26
Branches 3121 3121
============================================
- Hits 44285 44273 -12
+ Misses 111572 111558 -14
Partials 1877 1877
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dcdbd85
to
c770728
Compare
f4aee29
to
2023c50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement
- Massive reduction of Redis call - Stop handling expiration time of redis entries
2023c50
to
eb59e07
Compare
What is done
close #7913
Benchmark
We are testing two endpoints using batch simulation and pathfinding:
Tests are performed with everything cached locally. I'm guessing that the gain will be much greater in prod with network overhead.
Before
After