Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: fix wrong position of train times in timetable #8011

Merged
merged 1 commit into from
Jul 11, 2024
Merged

front: fix wrong position of train times in timetable #8011

merged 1 commit into from
Jul 11, 2024

Conversation

theocrsb
Copy link
Contributor

close #8009

@theocrsb theocrsb requested a review from a team as a code owner July 11, 2024 08:29
@theocrsb theocrsb force-pushed the tce/front/trainschedules/bug-wrong-position-of-train-times branch from 612e114 to b905cab Compare July 11, 2024 08:30
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.11%. Comparing base (bea61b1) to head (b905cab).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #8011      +/-   ##
============================================
- Coverage     28.12%   28.11%   -0.01%     
  Complexity     2075     2075              
============================================
  Files          1285     1285              
  Lines        157442   157442              
  Branches       3117     3117              
============================================
- Hits          44279    44268      -11     
- Misses       111290   111301      +11     
  Partials       1873     1873
Flag Coverage Δ
core 75.03% <ø> (ø)
editoast 70.81% <ø> (-0.04%) ⬇️
front 9.96% <ø> (ø)
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theocrsb theocrsb removed the request for review from clarani July 11, 2024 08:34
Akctarus
Akctarus approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, thank you for this fix !

emersion
emersion approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works

Math-R
Math-R approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and lgtm =)

@Math-R Math-R added this pull request to the merge queue Jul 11, 2024
Merged via the queue into dev with commit 7f4df2f Jul 11, 2024
17 checks passed
@Math-R Math-R deleted the tce/front/trainschedules/bug-wrong-position-of-train-times branch July 11, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion approved these changes

@Math-R Math-R Math-R approved these changes

@Akctarus Akctarus Akctarus approved these changes

@SharglutDev SharglutDev Awaiting requested review from SharglutDev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong position of train times in timetable
5 participants
@theocrsb @codecov-commenter @emersion @Math-R @Akctarus