Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: stdcm: add available simulation div #8058

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

Akctarus
Copy link
Contributor

closes #8056

@Akctarus Akctarus requested a review from a team as a code owner July 15, 2024 14:46
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 61 lines in your changes missing coverage. Please review.

Project coverage is 28.04%. Comparing base (580140d) to head (8582a03).

Files Patch % Lines
...ont/src/applications/stdcmV2/views/StdcmViewV2.tsx 0.00% 39 Missing and 1 partial ⚠️
...cmV2/components/StdcmResults/StdcmResultsTable.tsx 0.00% 12 Missing ⚠️
...s/stdcmV2/components/StdcmResults/StdcmResults.tsx 0.00% 9 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8058      +/-   ##
============================================
- Coverage     28.06%   28.04%   -0.02%     
  Complexity     2081     2081              
============================================
  Files          1289     1289              
  Lines        157717   157749      +32     
  Branches       3116     3116              
============================================
- Hits          44260    44242      -18     
- Misses       111582   111632      +50     
  Partials       1875     1875              
Flag Coverage Δ
core 75.11% <ø> (ø)
editoast 70.73% <ø> (-0.07%) ⬇️
front 9.90% <0.00%> (-0.01%) ⬇️
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 73.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus force-pushed the tmn/front/stdcm-available-simulation-pop-up branch 5 times, most recently from f90f9d8 to af64a42 Compare July 17, 2024 09:12
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Tested just a comment

front/src/applications/stdcmV2/views/StdcmViewV2.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done ! Tested

@Akctarus Akctarus force-pushed the tmn/front/stdcm-available-simulation-pop-up branch from ae6a30b to 581eadd Compare July 18, 2024 14:42
@Akctarus Akctarus force-pushed the tmn/front/stdcm-available-simulation-pop-up branch from 581eadd to 8582a03 Compare July 18, 2024 14:42
@Akctarus Akctarus enabled auto-merge July 18, 2024 14:42
@Akctarus Akctarus added this pull request to the merge queue Jul 18, 2024
Merged via the queue into dev with commit 8dea594 Jul 18, 2024
20 checks passed
@Akctarus Akctarus deleted the tmn/front/stdcm-available-simulation-pop-up branch July 18, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: stdcm: add available simulation message
4 participants