-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timestops margins #8077
Fix timestops margins #8077
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8077 +/- ##
============================================
- Coverage 28.06% 28.05% -0.02%
Complexity 2081 2081
============================================
Files 1289 1289
Lines 157704 157713 +9
Branches 3116 3116
============================================
- Hits 44265 44246 -19
- Misses 111564 111592 +28
Partials 1875 1875
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
front/src/modules/trainschedule/components/ManageTrainSchedule/helpers/formatMargin.ts
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/ManageTrainSchedule/helpers/formatMargin.ts
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/hooks/useSetupItineraryForTrainUpdate.ts
Outdated
Show resolved
Hide resolved
Thank you for spotting these. Should be fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
editoast throws an error when setting a 0% margin on origin but this is being discussed separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for tests/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (editoast; not tested)
e40515d
to
fff626a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm & tested
Editoast excpects front to send none for these cases
e547e54
to
bc52bb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Find a bug unrelated to this PR, lgtm
See commits for details
close #8066
close #8067