Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front:timestops: fix operational point removal #8080

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

SharglutDev
Copy link
Contributor

When an operational point in the timestops table was removed from via, it was removed from the store but not updated in the op list

close #8079

@SharglutDev SharglutDev requested a review from a team as a code owner July 16, 2024 14:07
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 28.05%. Comparing base (7a4590d) to head (e5f3f82).

Files Patch % Lines
front/src/modules/timesStops/utils.ts 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8080      +/-   ##
============================================
- Coverage     28.05%   28.05%   -0.01%     
  Complexity     2081     2081              
============================================
  Files          1289     1289              
  Lines        157717   157718       +1     
  Branches       3114     3114              
============================================
- Hits          44254    44244      -10     
- Misses       111588   111599      +11     
  Partials       1875     1875              
Flag Coverage Δ
core 75.19% <ø> (ø)
editoast 70.76% <ø> (-0.04%) ⬇️
front 9.90% <0.00%> (-0.01%) ⬇️
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested !

Copy link
Contributor

@achrafmohye achrafmohye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@SharglutDev SharglutDev force-pushed the pfn/front/timestops/fix-op-removal branch from 7ce13a7 to 8ee5089 Compare July 17, 2024 09:51
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

When an operational point in the timestops table was removed from via, it was removed from the store but not updated in the op list
@SharglutDev SharglutDev force-pushed the pfn/front/timestops/fix-op-removal branch from 8ee5089 to e5f3f82 Compare July 17, 2024 09:58
@SharglutDev SharglutDev added this pull request to the merge queue Jul 17, 2024
Merged via the queue into dev with commit 5676323 Jul 17, 2024
20 checks passed
@SharglutDev SharglutDev deleted the pfn/front/timestops/fix-op-removal branch July 17, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Margin/stop time remains after deleting waypoint
6 participants