-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: take step planned timing data into account in block availability #8085
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8085 +/- ##
=============================================
+ Coverage 28.07% 87.49% +59.41%
=============================================
Files 1289 31 -1258
Lines 157794 1535 -156259
Branches 3121 0 -3121
=============================================
- Hits 44301 1343 -42958
+ Misses 111616 192 -111424
+ Partials 1877 0 -1877
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
core/src/main/kotlin/fr/sncf/osrd/api/api_v2/stdcm/STDCMEndpointV2.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/stdcm/preprocessing/implementation/BlockAvailability.kt
Outdated
Show resolved
Hide resolved
5650bd4
to
f96e230
Compare
f96e230
to
07f9972
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass, I haven't checked the tests yet
Looks pretty good
core/src/main/kotlin/fr/sncf/osrd/stdcm/preprocessing/implementation/BlockAvailability.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/stdcm/preprocessing/implementation/BlockAvailability.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests look good as well
Careful though, there's an integration test that fails
core/src/test/kotlin/fr/sncf/osrd/stdcm/preprocessing/BlockAvailabilityTests.kt
Outdated
Show resolved
Hide resolved
core/src/test/kotlin/fr/sncf/osrd/stdcm/preprocessing/BlockAvailabilityTests.kt
Outdated
Show resolved
Hide resolved
core/src/test/kotlin/fr/sncf/osrd/stdcm/preprocessing/BlockAvailabilityTests.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/stdcm/preprocessing/implementation/BlockAvailability.kt
Outdated
Show resolved
Hide resolved
93c7099
to
ad02448
Compare
core/src/test/kotlin/fr/sncf/osrd/stdcm/preprocessing/BlockAvailabilityTests.kt
Outdated
Show resolved
Hide resolved
core/src/test/kotlin/fr/sncf/osrd/stdcm/preprocessing/BlockAvailabilityTests.kt
Outdated
Show resolved
Hide resolved
6d2c81e
to
a20af1c
Compare
a20af1c
to
d774c07
Compare
Fixes #7688.