Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: take step planned timing data into account in block availability #8085

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

Erashin
Copy link
Contributor

@Erashin Erashin commented Jul 17, 2024

Fixes #7688.

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.49%. Comparing base (f2d6885) to head (70ccba0).
Report is 43 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #8085       +/-   ##
=============================================
+ Coverage     28.07%   87.49%   +59.41%     
=============================================
  Files          1289       31     -1258     
  Lines        157794     1535   -156259     
  Branches       3121        0     -3121     
=============================================
- Hits          44301     1343    -42958     
+ Misses       111616      192   -111424     
+ Partials       1877        0     -1877     
Flag Coverage Δ
core ?
editoast ?
front ?
gateway ?
railjson_generator 87.49% <ø> (ø)
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Erashin Erashin force-pushed the alch/planned-step-availability branch 6 times, most recently from 5650bd4 to f96e230 Compare July 18, 2024 09:28
@Erashin Erashin marked this pull request as ready for review July 18, 2024 09:29
@Erashin Erashin requested a review from a team as a code owner July 18, 2024 09:29
@Erashin Erashin requested review from Khoyo and eckter July 18, 2024 09:29
@Erashin Erashin force-pushed the alch/planned-step-availability branch from f96e230 to 07f9972 Compare July 18, 2024 09:41
Copy link
Contributor

@eckter eckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, I haven't checked the tests yet

Looks pretty good

Copy link
Contributor

@eckter eckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests look good as well

Careful though, there's an integration test that fails

@Erashin Erashin force-pushed the alch/planned-step-availability branch 2 times, most recently from 93c7099 to ad02448 Compare July 19, 2024 07:55
@Erashin Erashin requested a review from eckter July 19, 2024 11:57
@Erashin Erashin force-pushed the alch/planned-step-availability branch 3 times, most recently from 6d2c81e to a20af1c Compare July 19, 2024 14:00
@Erashin Erashin enabled auto-merge July 19, 2024 14:01
@Erashin Erashin disabled auto-merge July 19, 2024 14:01
@Erashin Erashin force-pushed the alch/planned-step-availability branch from a20af1c to d774c07 Compare July 19, 2024 14:01
@Erashin Erashin enabled auto-merge July 19, 2024 14:02
@Erashin Erashin added this pull request to the merge queue Jul 19, 2024
Merged via the queue into dev with commit 2f6eb46 Jul 19, 2024
20 checks passed
@Erashin Erashin deleted the alch/planned-step-availability branch July 19, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: stdcm: generate occupations for points with specified times
4 participants