Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front, ci: bump node js (18 -> 20) #8089

Merged
merged 1 commit into from
Jul 17, 2024
Merged

front, ci: bump node js (18 -> 20) #8089

merged 1 commit into from
Jul 17, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Jul 17, 2024

closes #8088

@clarani clarani requested review from a team as code owners July 17, 2024 09:05
@clarani clarani requested a review from ElysaSrc July 17, 2024 09:05
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.05%. Comparing base (7a4590d) to head (3a708f4).
Report is 2 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8089      +/-   ##
============================================
- Coverage     28.05%   28.05%   -0.01%     
  Complexity     2081     2081              
============================================
  Files          1289     1289              
  Lines        157717   157718       +1     
  Branches       3114     3114              
============================================
- Hits          44254    44245       -9     
- Misses       111588   111598      +10     
  Partials       1875     1875              
Flag Coverage Δ
core 75.19% <ø> (ø)
editoast 70.76% <ø> (-0.04%) ⬇️
front 9.90% <ø> (-0.01%) ⬇️
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anisometropie
Copy link
Contributor

We should have a .nvmrc file to sync the dev environment with the docker containers
https://github.com/nvm-sh/nvm#nvmrc

@types/node major version should also match, but we already had "^20.11.16"

Copy link
Contributor

@ElysaSrc ElysaSrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI's working properly, tests are passing. I think it should be fine to merge this.

@ElysaSrc
Copy link
Contributor

We should have a .nvmrc file to sync the dev environment with the docker containers https://github.com/nvm-sh/nvm#nvmrc

@types/node major version should also match, but we already had "^20.11.16"

Done.

Copy link
Contributor Author

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm (not tested)

@clarani clarani added this pull request to the merge queue Jul 17, 2024
Merged via the queue into dev with commit d5aa8db Jul 17, 2024
20 checks passed
@clarani clarani deleted the cni/8088/bump-node-js branch July 17, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: bump node
5 participants