Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: stdcm: pre-filter requirements that are not in the range #8091

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Jul 17, 2024

Fix #7649

I haven't run an actual benchmark (some of the tooling isn't up to date for tsv2), but I checked that the payload are much smaller when the timetable spans over a large time frame

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 80 lines in your changes missing coverage. Please review.

Project coverage is 28.11%. Comparing base (4ea0853) to head (bec09fa).

Files Patch % Lines
editoast/src/views/v2/timetable/stdcm.rs 0.00% 80 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8091      +/-   ##
============================================
- Coverage     28.13%   28.11%   -0.03%     
  Complexity     2081     2081              
============================================
  Files          1289     1289              
  Lines        157789   157856      +67     
  Branches       3131     3131              
============================================
- Hits          44389    44376      -13     
- Misses       111510   111590      +80     
  Partials       1890     1890              
Flag Coverage Δ
core 75.11% <ø> (ø)
editoast 70.65% <0.00%> (-0.21%) ⬇️
front 9.98% <ø> (ø)
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 73.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter force-pushed the ech/pre-filter-requirements branch from 448a8ed to a2cf3af Compare July 18, 2024 08:18
@eckter eckter marked this pull request as ready for review July 18, 2024 08:40
@eckter eckter requested a review from a team as a code owner July 18, 2024 08:40
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! Thanks.

editoast/src/views/v2/timetable/stdcm.rs Outdated Show resolved Hide resolved
editoast/src/views/v2/timetable/stdcm.rs Outdated Show resolved Hide resolved
@eckter eckter force-pushed the ech/pre-filter-requirements branch from 90ae83f to 6c988d7 Compare July 18, 2024 09:18
@eckter eckter requested a review from flomonster July 18, 2024 09:21
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (reviewed + tested)

@eckter eckter force-pushed the ech/pre-filter-requirements branch from 6c988d7 to bec09fa Compare July 19, 2024 07:30
@eckter eckter enabled auto-merge July 19, 2024 07:31
@eckter eckter added this pull request to the merge queue Jul 19, 2024
Merged via the queue into dev with commit 987512c Jul 19, 2024
20 checks passed
@eckter eckter deleted the ech/pre-filter-requirements branch July 19, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editoast: stdcm: pre-filter train requirements that can't affect the new train
3 participants