Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: check input size of train name and update checkfields methods #8094

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

theocrsb
Copy link
Contributor

close #8051

@theocrsb theocrsb requested a review from a team as a code owner July 17, 2024 12:27
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 22.72727% with 34 lines in your changes missing coverage. Please review.

Project coverage is 27.18%. Comparing base (a6f39ee) to head (3062845).

Files Patch % Lines
front/src/modules/project/utils.ts 0.00% 11 Missing and 1 partial ⚠️
...e/components/ManageTrainSchedule/TrainSettings.tsx 0.00% 7 Missing ⚠️
front/src/modules/study/utils.ts 0.00% 6 Missing ⚠️
front/src/modules/scenario/utils.ts 0.00% 4 Missing and 1 partial ⚠️
...les/scenario/components/AddOrEditScenarioModal.tsx 0.00% 2 Missing ⚠️
front/src/applications/operationalStudies/utils.ts 75.00% 1 Missing ⚠️
front/src/utils/strings.ts 87.50% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #8094   +/-   ##
=========================================
  Coverage     27.18%   27.18%           
  Complexity     2127     2127           
=========================================
  Files          1310     1310           
  Lines        157738   157770   +32     
  Branches       3257     3257           
=========================================
+ Hits          42878    42887    +9     
- Misses       112880   112903   +23     
  Partials       1980     1980           
Flag Coverage Δ
core 75.44% <ø> (ø)
editoast 64.21% <ø> (-0.01%) ⬇️
front 10.38% <22.72%> (+<0.01%) ⬆️
gateway 2.03% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 73.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theocrsb theocrsb force-pushed the tce/front/trainschedules/check-input-size-train-name branch 2 times, most recently from eb2d799 to 98bb85a Compare July 22, 2024 09:57
@theocrsb theocrsb requested a review from clarani July 22, 2024 09:59
@theocrsb theocrsb force-pushed the tce/front/trainschedules/check-input-size-train-name branch 3 times, most recently from 33000ec to 8a5ecf5 Compare July 25, 2024 06:59
@theocrsb theocrsb requested a review from clarani July 25, 2024 07:04
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & tested ✅

@theocrsb theocrsb requested review from Uriel-Sautron and removed request for RomainValls July 28, 2024 10:34
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Tested, good job.
Just a comment.

@theocrsb theocrsb force-pushed the tce/front/trainschedules/check-input-size-train-name branch from 8a5ecf5 to 7386d53 Compare July 29, 2024 09:21
front/src/applications/operationalStudies/utils.ts Outdated Show resolved Hide resolved
front/src/utils/strings.ts Outdated Show resolved Hide resolved
@theocrsb theocrsb force-pushed the tce/front/trainschedules/check-input-size-train-name branch 3 times, most recently from 887bb65 to c1b17ea Compare July 29, 2024 12:08
@theocrsb theocrsb force-pushed the tce/front/trainschedules/check-input-size-train-name branch from c1b17ea to 3062845 Compare July 29, 2024 12:08
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@theocrsb theocrsb added this pull request to the merge queue Jul 29, 2024
Merged via the queue into dev with commit 7bca69b Jul 29, 2024
20 checks passed
@theocrsb theocrsb deleted the tce/front/trainschedules/check-input-size-train-name branch July 29, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: no specific error message when input is too long
4 participants