-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: check input size of train name and update checkfields methods #8094
front: check input size of train name and update checkfields methods #8094
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8094 +/- ##
=========================================
Coverage 27.18% 27.18%
Complexity 2127 2127
=========================================
Files 1310 1310
Lines 157738 157770 +32
Branches 3257 3257
=========================================
+ Hits 42878 42887 +9
- Misses 112880 112903 +23
Partials 1980 1980
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
front/public/locales/en/operationalStudies/manageTrainSchedule.json
Outdated
Show resolved
Hide resolved
eb2d799
to
98bb85a
Compare
front/src/modules/trainschedule/components/ManageTrainSchedule/TrainSettings.tsx
Outdated
Show resolved
Hide resolved
33000ec
to
8a5ecf5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM & tested ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !! Tested, good job.
Just a comment.
front/src/modules/trainschedule/components/ManageTrainSchedule/TrainSettings.tsx
Outdated
Show resolved
Hide resolved
8a5ecf5
to
7386d53
Compare
887bb65
to
c1b17ea
Compare
c1b17ea
to
3062845
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
close #8051