core: fix: follow scheduled point even if faster than margins #8096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eckter
force-pushed
the
ech/fix-allowances
branch
from
5e50b74
to
e270638
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8096 +/- ##
============================================
- Coverage 28.05% 28.05% -0.01%
Complexity 2081 2081
============================================
Files 1289 1289
Lines 157718 157754 +36
Branches 3114 3116 +2
============================================
+ Hits 44251 44254 +3
- Misses 111592 111625 +33
Partials 1875 1875
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eckter
force-pushed
the
ech/fix-allowances
branch
from
e270638
to
bc246d3
Compare
Khoyo
reviewed
Jul 17, 2024
core/src/main/kotlin/fr/sncf/osrd/standalone_sim/StandaloneSimulation.kt
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/standalone_sim/StandaloneSimulation.kt
Show resolved
Hide resolved
Erashin
approved these changes
Jul 18, 2024
Khoyo
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8092
We don't quite handle it perfectly yet: when we need to go faster than the margins, we ignore the time repartitions among different margin ranges (between the faulty pair of scheduled points).