Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: replace DbPoolV1 by V2 in views::pathfinding #8098

Closed
wants to merge 1 commit into from

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Jul 17, 2024

Part of #6980

@hamz2a hamz2a requested a review from a team as a code owner July 17, 2024 15:39
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 93.10345% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.06%. Comparing base (7a4590d) to head (1809c66).
Report is 3 commits behind head on dev.

Files Patch % Lines
editoast/src/views/pathfinding/mod.rs 88.57% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #8098   +/-   ##
=========================================
  Coverage     28.05%   28.06%           
  Complexity     2081     2081           
=========================================
  Files          1289     1289           
  Lines        157717   157761   +44     
  Branches       3114     3114           
=========================================
+ Hits          44254    44274   +20     
- Misses       111588   111612   +24     
  Partials       1875     1875           
Flag Coverage Δ
core 75.19% <ø> (ø)
editoast 70.78% <93.10%> (-0.02%) ⬇️
front 9.90% <ø> (-0.01%) ⬇️
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

views::pathfinding will be droped soon. Is it worth it to do this code refactoring?

@hamz2a
Copy link
Contributor Author

hamz2a commented Jul 18, 2024

views::pathfinding will be droped soon. Is it worth it to do this code refactoring?

I didn't know that it will be removed soon. I will close the PR.

@hamz2a hamz2a closed this Jul 18, 2024
@hamz2a
Copy link
Contributor Author

hamz2a commented Jul 18, 2024

views::pathfinding will be droped soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants