stdcm: simulation report map is not showing the path #8256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarahBellaha
force-pushed
the
sba/front/fix-stdcm-map-8016
branch
3 times, most recently
from
0dba8e4
to
607963f
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8256 +/- ##
============================================
- Coverage 36.91% 36.83% -0.08%
- Complexity 2175 2177 +2
============================================
Files 1279 1254 -25
Lines 118972 113661 -5311
Branches 3188 3202 +14
============================================
- Hits 43922 41871 -2051
+ Misses 73165 69896 -3269
- Partials 1885 1894 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SarahBellaha
force-pushed
the
sba/front/fix-stdcm-map-8016
branch
3 times, most recently
from
6611820
to
df40bf3
Compare
emersion
reviewed
Aug 6, 2024
There was a problem hiding this comment.
Seems like this TypeScript error pops up:
[TypeScript] Type '{ hideAttribution: true; hideItinerary: true; preventPointSelection: true; pathProperties: ManageTrainSchedulePathProperties | undefined; }' is not assignable to type 'IntrinsicAttributes & MapProps'. Property 'preventPointSelection' does not exist on type 'IntrinsicAttributes & MapProps'.
/app/src/applications/stdcmV2/components/StdcmConfig.tsx:115:44
By spamming clicks on the map markers (when the cursor appears as a hand), I can get it in a weird state where the markers are offset:
(Could maybe be fixed with pointer-events: none?)
front/src/modules/trainschedule/components/ManageTrainSchedule/Map.tsx
Outdated
Show resolved
Hide resolved
SarahBellaha
force-pushed
the
sba/front/fix-stdcm-map-8016
branch
3 times, most recently
from
1e3f06f
to
75a29a6
Compare
SarahBellaha
force-pushed
the
sba/front/fix-stdcm-map-8016
branch
from
75a29a6
to
e822f60
Compare
SharglutDev
requested changes
Aug 29, 2024
...s/trainschedule/components/ManageTrainSchedule/ManageTrainScheduleMap/ItineraryMarkersV2.tsx
Outdated
Show resolved
Hide resolved
...s/trainschedule/components/ManageTrainSchedule/ManageTrainScheduleMap/ItineraryMarkersV2.tsx
Show resolved
Hide resolved
SarahBellaha
force-pushed
the
sba/front/fix-stdcm-map-8016
branch
from
e822f60
to
d62f480
Compare
SharglutDev
approved these changes
Aug 30, 2024
emersion
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8016
Closes #8198
Closes #8620