Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete Train Schedule V1 endpoints #8275

Merged
merged 8 commits into from
Aug 29, 2024
Merged

Conversation

younesschrifi
Copy link
Contributor

@younesschrifi younesschrifi commented Aug 1, 2024

Close #8264
Close #8263

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 82.60870% with 28 lines in your changes missing coverage. Please review.

Project coverage is 36.78%. Comparing base (8245ae5) to head (f7b9ae4).
Report is 10 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/common/types.ts 0.00% 6 Missing ⚠️
...rc/applications/operationalStudies/views/Study.tsx 0.00% 4 Missing ⚠️
...ions/operationalStudies/components/BreadCrumbs.tsx 0.00% 2 Missing ⚠️
...riction/components/PowerRestrictionsSelectorV2.tsx 0.00% 2 Missing ⚠️
...striction/hooks/usePowerRestrictionSelectorData.ts 0.00% 2 Missing ⚠️
...les/scenario/components/AddOrEditScenarioModal.tsx 0.00% 2 Missing ⚠️
...t/src/modules/scenario/components/ScenarioCard.tsx 0.00% 2 Missing ⚠️
...scenario/components/ScenarioExplorer/MiniCards.tsx 0.00% 2 Missing ⚠️
...ponents/ScenarioExplorer/ScenarioExplorerModal.tsx 0.00% 2 Missing ⚠️
...nt/src/modules/stdcmAllowances/allowancesConsts.ts 0.00% 0 Missing and 1 partial ⚠️
... and 3 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8275      +/-   ##
============================================
- Coverage     36.91%   36.78%   -0.13%     
  Complexity     2175     2175              
============================================
  Files          1279     1254      -25     
  Lines        118972   113511    -5461     
  Branches       3188     3187       -1     
============================================
- Hits          43915    41760    -2155     
+ Misses        73172    69867    -3305     
+ Partials       1885     1884       -1     
Flag Coverage Δ
core 74.87% <ø> (ø)
editoast 71.69% <100.00%> (+5.51%) ⬆️
front 14.90% <67.50%> (-0.95%) ⬇️
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 85.91% <97.29%> (+12.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@younesschrifi younesschrifi force-pushed the yci/delete-tsv1-endpoint branch 6 times, most recently from 5b8b096 to 9ed6759 Compare August 1, 2024 21:34
@younesschrifi younesschrifi force-pushed the yci/delete-tsv1-endpoint branch 12 times, most recently from 6c92cfc to a72a4d9 Compare August 13, 2024 17:11
@younesschrifi younesschrifi marked this pull request as ready for review August 13, 2024 17:11
@younesschrifi younesschrifi requested review from a team as code owners August 13, 2024 17:11
@younesschrifi younesschrifi force-pushed the yci/delete-tsv1-endpoint branch 6 times, most recently from ad85c13 to 3b81d89 Compare August 13, 2024 23:40
@younesschrifi younesschrifi force-pushed the yci/delete-tsv1-endpoint branch 7 times, most recently from 20adb70 to 873f7e1 Compare August 22, 2024 22:35
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Feel free to close my comments

front/src/utils/types.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🗑️ ♻️ 🧹

editoast/src/models/mod.rs Outdated Show resolved Hide resolved
@younesschrifi younesschrifi force-pushed the yci/delete-tsv1-endpoint branch 5 times, most recently from ec20cf9 to dc55996 Compare August 29, 2024 13:38
@younesschrifi younesschrifi added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@younesschrifi younesschrifi added this pull request to the merge queue Aug 29, 2024
Merged via the queue into dev with commit 6f482ef Aug 29, 2024
22 checks passed
@younesschrifi younesschrifi deleted the yci/delete-tsv1-endpoint branch August 29, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DROP TSV1: delete endpoints editoast DROP TSV1: migrate tables
6 participants