Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add roles check to rolling stocks #8362

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Aug 8, 2024

No description provided.

@Wadjetz Wadjetz self-assigned this Aug 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 67.41573% with 29 lines in your changes missing coverage. Please review.

Project coverage is 36.85%. Comparing base (80973c5) to head (057c27f).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/views/rolling_stocks/mod.rs 65.62% 22 Missing ⚠️
editoast/src/views/light_rolling_stocks.rs 75.00% 6 Missing ⚠️
editoast/editoast_authz/src/builtin_role.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #8362   +/-   ##
=========================================
  Coverage     36.84%   36.85%           
  Complexity     2175     2175           
=========================================
  Files          1279     1279           
  Lines        118794   118883   +89     
  Branches       3188     3188           
=========================================
+ Hits          43774    43817   +43     
- Misses        73135    73181   +46     
  Partials       1885     1885           
Flag Coverage Δ
core 74.87% <ø> (ø)
editoast 66.04% <67.41%> (-0.06%) ⬇️
front 15.84% <ø> (ø)
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz force-pushed the ebe/editoast-add-roles-check-to-rolling-stocks branch from 4a0db4a to f485e41 Compare August 8, 2024 09:16
@Wadjetz Wadjetz marked this pull request as ready for review August 9, 2024 08:05
@Wadjetz Wadjetz requested a review from a team as a code owner August 9, 2024 08:05
@Wadjetz Wadjetz force-pushed the ebe/editoast-add-roles-check-to-rolling-stocks branch from f485e41 to 689181d Compare August 9, 2024 08:06
Copy link
Contributor

@hamz2a hamz2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Wadjetz Wadjetz force-pushed the ebe/editoast-add-roles-check-to-rolling-stocks branch 2 times, most recently from 6b18ec4 to 386d0dd Compare August 12, 2024 08:49
@Wadjetz Wadjetz requested a review from Tguisnet August 14, 2024 07:33
@hamz2a hamz2a mentioned this pull request Aug 21, 2024
28 tasks
@Wadjetz Wadjetz force-pushed the ebe/editoast-add-roles-check-to-rolling-stocks branch from 386d0dd to 907e91a Compare August 29, 2024 08:26
@Wadjetz Wadjetz requested a review from leovalais August 29, 2024 08:33
@Wadjetz Wadjetz force-pushed the ebe/editoast-add-roles-check-to-rolling-stocks branch from 907e91a to 057c27f Compare August 29, 2024 08:35
@Wadjetz Wadjetz added this pull request to the merge queue Aug 29, 2024
Merged via the queue into dev with commit 811a2ec Aug 29, 2024
22 checks passed
@Wadjetz Wadjetz deleted the ebe/editoast-add-roles-check-to-rolling-stocks branch August 29, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants