front: convert times from NGE to OSRD

[emersion]

• isNonStopTransit makes NGE blow up with NaN when editing times
• Somehow times are updated on the backend but the frontend refuses to display the new information? Yes, see: front: output table does not display schedule for op via #8555

Closes: #8389

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 1.38889% with 71 lines in your changes missing coverage. Please review.

Project coverage is 37.01%. Comparing base (c268b4a) to head (d031d8e).
Report is 4 commits behind head on dev.

Files	Patch %	Lines
...ationalStudies/components/MacroEditor/ngeToOsrd.ts	0.00%	70 Missing ⚠️
front/src/utils/date.ts	0.00%	0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #8416      +/-   ##
============================================
- Coverage     37.04%   37.01%   -0.03%     
  Complexity     2165     2165              
============================================
  Files          1267     1267              
  Lines        117203   117262      +59     
  Branches       3139     3139              
============================================
- Hits          43413    43408       -5     
- Misses        71948    72012      +64     
  Partials       1842     1842              

Flag	Coverage Δ
core	74.94% <ø> (ø)
editoast	66.40% <ø> (-0.03%)	⬇️
front	15.76% <1.38%> (-0.02%)	⬇️
gateway	2.20% <ø> (ø)
osrdyne	2.71% <ø> (ø)
railjson_generator	87.49% <ø> (ø)
tests	73.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[louisgreiner]

It looks like changing the source arrival time for the first section also changes the departure time (caused directly by NGE times propagation).
It then schedules the start and next stop of the train schedule in OSRD.
In addition, the travel time is always 0, don't we want to play with it to adjust the differents times ?

[louisgreiner]

isNonStopTransit sets the times at 0. It would be nice to set 2' of stopping time at this point, but since we don't deal with simulation results yet, i wonder how to deal with that :(

Before:

After:

[emersion]

Right, isNonStopTransit is not handled in this PR at all (left as a TODO).

[SharglutDev]

Another weird thing : when creating a train with a via in NGE and asking the train to stop at this via, the output table is properly updated with the stop but not the input table.

[louisgreiner]

Interacting with NGE times triggers a POST v2/trainschedule/ that leads to a 404, I think it is related with UpsertedTrainSchedules feature. Is it in the scope of that PR ? I'm not sure to understand what it does and if the error is important

[emersion]

Interacting with NGE times triggers a POST v2/trainschedule/ that leads to a 404, I think it is related with UpsertedTrainSchedules feature. Is it in the scope of that PR ? I'm not sure to understand what it does and if the error is important

I believe this bug happens without this PR as well.

[louisgreiner]

Tested and LGTM. Thanks a lot for this precious feature 💯

[SharglutDev]

Lgtm and tested. The input table issue will be done in a different PR.