core, editoast, front: stop using speed-limit tags' long names #8417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8417 +/- ##
============================================
+ Coverage 37.03% 37.06% +0.03%
+ Complexity 2212 2209 -3
============================================
Files 1253 1255 +2
Lines 113882 114079 +197
Branches 3188 3182 -6
============================================
+ Hits 42176 42286 +110
- Misses 69810 69901 +91
+ Partials 1896 1892 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bougue-pe
force-pushed
the
peb/rm_speed_limit_tags_long_name
branch
from
fe171cd
to
1951daa
Compare
bougue-pe
force-pushed
the
peb/rm_speed_limit_tags_long_name
branch
3 times, most recently
from
03c1305
to
7e4bb8f
Compare
bougue-pe
force-pushed
the
peb/rm_speed_limit_tags_long_name
branch
from
7e4bb8f
to
bdf7d07
Compare
woshilapin
approved these changes
Sep 9, 2024
|
Fixed integration tests in ddc2d2f (@shenriotpro may re-review) |
bougue-pe
force-pushed
the
peb/rm_speed_limit_tags_long_name
branch
from
ddc2d2f
to
fbb19a4
Compare
flomonster
approved these changes
Sep 11, 2024
* stop fallback on long-names (core) * remove short-id extractors (front) * adapt examples and small_infra also remove default-speed, as it is unused Signed-off-by: Pierre-Etienne Bougué <[email protected]>
bougue-pe
force-pushed
the
peb/rm_speed_limit_tags_long_name
branch
from
fbb19a4
to
6caffd5
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also remove default-speed, as it is unused
Resolves #7977
🔍
This PR can be reviewed, but not merged👇TODO: