Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix a crash that would happen when editing a train #8503

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

anisometropie
Copy link
Contributor

@anisometropie anisometropie commented Aug 20, 2024

Closes #8377.

@anisometropie anisometropie requested a review from a team as a code owner August 20, 2024 17:45
@anisometropie anisometropie marked this pull request as draft August 20, 2024 17:45
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 36.83%. Comparing base (7a8685f) to head (92ad23f).
Report is 30 commits behind head on dev.

Files Patch % Lines
...ions/operationalStudies/hooks/useLazyLoadTrains.ts 0.00% 27 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8503      +/-   ##
============================================
- Coverage     36.83%   36.83%   -0.01%     
- Complexity     2169     2175       +6     
============================================
  Files          1280     1280              
  Lines        118631   118826     +195     
  Branches       3184     3189       +5     
============================================
+ Hits          43694    43764      +70     
- Misses        73054    73176     +122     
- Partials       1883     1886       +3     
Flag Coverage Δ
core 74.87% <ø> (+<0.01%) ⬆️
editoast 66.05% <ø> (-0.12%) ⬇️
front 15.84% <0.00%> (-0.01%) ⬇️
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anisometropie anisometropie changed the title s front: fix a crash that would happen when editing a train Aug 21, 2024
@anisometropie anisometropie marked this pull request as ready for review August 21, 2024 07:59
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Tested

Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested ✅

the two rtk-query calls postV2TrainSchedule & postV2TrainScheduleSimulationSummary do not happen during the same react cycle.

if we update a train, one is going to re-fetch first and the 2 are out of sync during a few cycles, which fails an assert.
@anisometropie anisometropie added this pull request to the merge queue Aug 23, 2024
Merged via the queue into dev with commit 6d020d8 Aug 23, 2024
22 checks passed
@anisometropie anisometropie deleted the vcs/8377 branch August 23, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Front crash when edit input table for a specific scenario
5 participants