-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix a crash that would happen when editing a train #8503
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8503 +/- ##
============================================
- Coverage 36.83% 36.83% -0.01%
- Complexity 2169 2175 +6
============================================
Files 1280 1280
Lines 118631 118826 +195
Branches 3184 3189 +5
============================================
+ Hits 43694 43764 +70
- Misses 73054 73176 +122
- Partials 1883 1886 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3f94de8
to
01a57bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
3e098d9
to
61e523b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested ✅
front/src/applications/operationalStudies/hooks/useLazyLoadTrains.ts
Outdated
Show resolved
Hide resolved
the two rtk-query calls postV2TrainSchedule & postV2TrainScheduleSimulationSummary do not happen during the same react cycle. if we update a train, one is going to re-fetch first and the 2 are out of sync during a few cycles, which fails an assert.
61e523b
to
92ad23f
Compare
Closes #8377.