Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rolling stock related schedules list endpoint #8564

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Add rolling stock related schedules list endpoint #8564

merged 1 commit into from
Sep 4, 2024

Conversation

Sh099078
Copy link
Contributor

Fixes #8078

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.13%. Comparing base (43a9891) to head (5af2430).
Report is 37 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@              Coverage Diff              @@
##                dev    #8564       +/-   ##
=============================================
+ Coverage     36.85%   67.13%   +30.28%     
+ Complexity     2217     2213        -4     
=============================================
  Files          1255      663      -592     
  Lines        113827    47756    -66071     
  Branches       3187     2085     -1102     
=============================================
- Hits          41951    32063     -9888     
+ Misses        69984    14894    -55090     
+ Partials       1892      799     -1093
Flag Coverage Δ
core 74.75% <ø> (-0.02%) ⬇️
editoast 71.83% <100.00%> (+0.03%) ⬆️
front ?
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sh099078 Sh099078 force-pushed the lf/rolling-stock-schedules branch 6 times, most recently from e4ef7b5 to b7e0196 Compare August 27, 2024 14:19
@Sh099078 Sh099078 marked this pull request as ready for review August 27, 2024 15:10
@Sh099078 Sh099078 requested a review from a team as a code owner August 27, 2024 15:10
leovalais
leovalais requested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! A few remarks. Don't hesitate to answer if something's not clear or if you disagree with something :)

Not tested yet.

editoast/src/modelsv2/rolling_stock_model/schedules_from_rolling_stock.rs Outdated Show resolved Hide resolved
editoast/src/modelsv2/rolling_stock_model/schedules_from_rolling_stock.rs Outdated Show resolved Hide resolved
editoast/src/modelsv2/rolling_stock_model/schedules_from_rolling_stock.rs Outdated Show resolved Hide resolved
editoast/src/modelsv2/rolling_stock_model/schedules_from_rolling_stock.rs Outdated Show resolved Hide resolved
editoast/src/modelsv2/rolling_stock_model/schedules_from_rolling_stock.rs Outdated Show resolved Hide resolved
editoast/src/views/rolling_stocks/mod.rs Outdated Show resolved Hide resolved
woshilapin
woshilapin approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the expert comments from @leovalais 😗, the rest looks good. Thank you.

editoast/src/modelsv2/rolling_stock_model.rs Outdated Show resolved Hide resolved
@Sh099078 Sh099078 force-pushed the lf/rolling-stock-schedules branch 6 times, most recently from 61404ad to d549513 Compare August 30, 2024 14:12
@Sh099078 Sh099078 force-pushed the lf/rolling-stock-schedules branch 2 times, most recently from 9692f7a to 6eefddd Compare September 1, 2024 13:44
leovalais
leovalais requested changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few last changes. Otherwise tested and it works great! 😁

editoast/openapi.yaml Outdated Show resolved Hide resolved
editoast/src/modelsv2/rolling_stock_model/schedules_from_rolling_stock.rs Outdated Show resolved Hide resolved
editoast/src/modelsv2/rolling_stock_model/schedules_from_rolling_stock.rs Outdated Show resolved Hide resolved
editoast/src/views/rolling_stocks/mod.rs Outdated Show resolved Hide resolved
editoast/src/modelsv2/rolling_stock_model/schedules_from_rolling_stock.rs Outdated Show resolved Hide resolved
editoast/src/modelsv2/rolling_stock_model/schedules_from_rolling_stock.rs Outdated Show resolved Hide resolved
@leovalais
Copy link
Contributor

Sad to see the result of our Option bikeshed go away though 😞

@Sh099078 Sh099078 force-pushed the lf/rolling-stock-schedules branch 2 times, most recently from 8c5be5d to 30643aa Compare September 2, 2024 14:24
leovalais
leovalais approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you (I unresolved a comment).

Note

You may want to squash your commits.

editoast/openapi.yaml Outdated Show resolved Hide resolved
@Sh099078
editoast: add rolling stock usage endoint
5af2430 
This endpoint returns the list of train
schedules associated with a given rolling
stock.
@Sh099078 Sh099078 added this pull request to the merge queue Sep 4, 2024
Merged via the queue into dev with commit 0297e75 Sep 4, 2024
22 checks passed
@Sh099078 Sh099078 deleted the lf/rolling-stock-schedules branch September 4, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Khoyo Khoyo Khoyo left review comments

@woshilapin woshilapin woshilapin approved these changes

@flomonster flomonster flomonster left review comments

@leovalais leovalais leovalais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create an endpoint that lists the train schedules a rolling stock is used in
6 participants
@Sh099078 @codecov-commenter @leovalais @Khoyo @woshilapin @flomonster