Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: osrd recognizes secondary code as BV, 00, or an empty string if no secondary code is provided by the user in macroscopic mode. #8748

Merged
merged 1 commit into from
Sep 11, 2024
Merged

front: osrd recognizes secondary code as BV, 00, or an empty string if no secondary code is provided by the user in macroscopic mode. #8748

merged 1 commit into from
Sep 11, 2024

Conversation

Caracol3
Copy link

@Caracol3 Caracol3 commented Sep 4, 2024 •
edited
Loading

close #8396

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 69 lines in your changes missing coverage. Please review.

Project coverage is 37.05%. Comparing base (a902ca2) to head (a715745).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ationalStudies/components/MacroEditor/ngeToOsrd.ts 0.00% 68 Missing ⚠️
...applications/operationalStudies/views/Scenario.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #8748      +/-   ##
============================================
- Coverage     37.07%   37.05%   -0.03%     
  Complexity     2212     2212              
============================================
  Files          1255     1255              
  Lines        114111   114170      +59     
  Branches       3189     3189              
============================================
- Hits          42307    42300       -7     
- Misses        69907    69973      +66     
  Partials       1897     1897
Flag Coverage Δ
core 74.79% <ø> (ø)
editoast 72.40% <ø> (-0.03%) ⬇️
front 14.92% <0.00%> (-0.02%) ⬇️
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Caracol3 Caracol3 force-pushed the mcy/front-recognize-nge-node-with-corresponding-secondary-code-in-osrd branch 2 times, most recently from 53261ce to 84d5e6e Compare September 5, 2024 07:46
@Caracol3 Caracol3 marked this pull request as ready for review September 5, 2024 09:29
@Caracol3 Caracol3 requested a review from a team as a code owner September 5, 2024 09:29
@Caracol3 Caracol3 added area:front Work on Standard OSRD Interface modules module:operational-studies Multi-train simulation with structured studies management labels Sep 5, 2024
@Caracol3 Caracol3 force-pushed the mcy/front-recognize-nge-node-with-corresponding-secondary-code-in-osrd branch from 84d5e6e to 62229c9 Compare September 5, 2024 13:07
@Caracol3 Caracol3 force-pushed the mcy/front-recognize-nge-node-with-corresponding-secondary-code-in-osrd branch from 62229c9 to 640b21d Compare September 6, 2024 09:38
achrafmohye
achrafmohye approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@achrafmohye achrafmohye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Caracol3 Caracol3 force-pushed the mcy/front-recognize-nge-node-with-corresponding-secondary-code-in-osrd branch from 640b21d to e79db2f Compare September 10, 2024 14:16
kmer2016
kmer2016 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@louisgreiner louisgreiner force-pushed the mcy/front-recognize-nge-node-with-corresponding-secondary-code-in-osrd branch 2 times, most recently from d107198 to 4263107 Compare September 11, 2024 09:26
@louisgreiner louisgreiner added this pull request to the merge queue Sep 11, 2024
@louisgreiner louisgreiner removed this pull request from the merge queue due to a manual request Sep 11, 2024
@louisgreiner louisgreiner force-pushed the mcy/front-recognize-nge-node-with-corresponding-secondary-code-in-osrd branch 2 times, most recently from 694deb9 to a715745 Compare September 11, 2024 12:14
@louisgreiner louisgreiner added this pull request to the merge queue Sep 11, 2024
Merged via the queue into dev with commit 4350e4c Sep 11, 2024
23 checks passed
@louisgreiner louisgreiner deleted the mcy/front-recognize-nge-node-with-corresponding-secondary-code-in-osrd branch September 11, 2024 12:44
@louisgreiner louisgreiner mentioned this pull request Sep 12, 2024
Closed
@louisgreiner
front: osrd recognizes secondary code as BV, 00, or an empty string i…
a715745 
…f no secondary code is provided by the user in macroscopic mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achrafmohye achrafmohye achrafmohye approved these changes

@kmer2016 kmer2016 kmer2016 approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules module:operational-studies Multi-train simulation with structured studies management
Projects
None yet
Milestone
No milestone
5 participants
@Caracol3 @codecov-commenter @kmer2016 @achrafmohye @louisgreiner