-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: redesign of the list of trains on the results page #8765
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8765 +/- ##
============================================
+ Coverage 37.05% 37.13% +0.07%
Complexity 2211 2211
============================================
Files 1260 1260
Lines 114820 114899 +79
Branches 3223 3223
============================================
+ Hits 42551 42672 +121
+ Misses 70337 70295 -42
Partials 1932 1932
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c41c644
to
fa398c7
Compare
46341a2
to
a809797
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Great work! Not much to say on the code side, just a small CSS suggestion. However, I have a few questions regarding the behavior:
-
When clicking the checkbox on a TrainCard, the corresponding train gets selected, and the curves and output tables are updated with that train's info. Previously, the train was selected by clicking on the TrainCard itself, not the checkbox.
-
In a new scenario, the 'No train' checkbox is always checked and cannot be unchecked.
-
There's no longer any distinction for trains on which path projection has been performed.
-
The hover effect on the first action button doesn't turn white like the others."
front/src/styles/scss/applications/operationalStudies/_scenario.scss
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/Timetable/TimetableTrainCard.tsx
Outdated
Show resolved
Hide resolved
This is done for the hover and scroll bar. |
I pushed a solution for the checkbox problem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
312d77a
to
02f9614
Compare
Co-authored-by: Simon Ser <[email protected]> Signed-off-by: theocrsb <[email protected]> Signed-off-by: Simon Ser <[email protected]>
Co-authored-by: Simon Ser <[email protected]> Signed-off-by: theocrsb <[email protected]> Signed-off-by: Simon Ser <[email protected]>
02f9614
to
559b79c
Compare
Mockup: https://www.sketch.com/s/2fb064cd-c483-46ac-bd30-72705fd63e75/a/el9lZmq
Closes #8601