Structure Refactor and Duplicate Trait Support #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
impreso
reviewed
Oct 7, 2022
| hooks: | ||
| - id: flake8 | ||
| additional_dependencies: [flake8-bugbear, pep8-naming] | ||
| # - repo: https://gitlab.com/pycqa/flake8 |
There was a problem hiding this comment.
you need to fix it in github actions as well , otherwise the build fails.
impreso
reviewed
Oct 7, 2022
| ) -> list[AttributeStatistic]: | ||
| return [ | ||
| { | ||
| **attr, |
There was a problem hiding this comment.
let's not use ** syntax , i think it's hard to read
impreso
reviewed
Oct 7, 2022
| from open_rarity.models.collections import AttributeCounted, AttributeStatistic | ||
|
|
||
|
|
||
| def information_content( |
impreso
reviewed
Oct 7, 2022
| """ | ||
| return list( | ||
| chain( | ||
| *[ |
There was a problem hiding this comment.
let's not use * , and ** i always find them unintuitive in the code.
impreso
reviewed
Oct 7, 2022
| _description_ | ||
| """ | ||
| d = defaultdict(int) | ||
| for key, count in groupapply(tokens, extract_token_name_key, "count").items(): |
There was a problem hiding this comment.
Not in favor of additional dependencies - can we have a list of dependencies and discuss what's needed and what's not?
impreso
reviewed
Oct 7, 2022
| from open_rarity.models.tokens import TokenAttributeStatistic | ||
|
|
||
|
|
||
| def unique_trait_count( |
There was a problem hiding this comment.
Naming utc clashes with utc timestamp - better naming will help us perhaps?
impreso
reviewed
Oct 7, 2022
|
|
||
| def __init__(self) -> None: | ||
| # OpenRarity uses InformationContent as the scoring algorithm of choice. | ||
| self.handler = InformationContentScoringHandler() | ||
| self.handler = IC() |
There was a problem hiding this comment.
I think we should be more explicit here - i like more InformationContent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two main goals...
Additionally, a breaking change that moves the "entrypoint" of the library from a scorer interface to a collection has been made.