-
Notifications
You must be signed in to change notification settings - Fork 54
Do CA checks to verify authentication by default #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This is a follow-up to b665b28. An attacker that is able to login into a token could bypass authentication by using its own certificate with any valid signature. This change makes the default "ca, signature" with the only way to disable CA check by using "no_ca". This, however, also makes the "none" option disabling CRL and OCSP checks only. Resolves OpenSC#80
Updated the commit with the suggestions, and made an attempt to update the documentation, too. |
Co-authored-by: Jakub Jelen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why the ci fails though
@frankmorgner , what do you think about the proposed change? You were the starter! :-) IMHO, the change seems to be logical. However, if applied, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I personally would change the explanation of the none
setting (in manual and example configuration) to something like:
# "none" included for legacy reasons, is equivalent to "ca,signature"
This legacy option should then be moved to the bottom of the lists
I just realized that the code already has support for |
Wow, I like the idea. |
This change allows to individualy set configuration.policy.ocsp_policy=OCSP_NONE and configuration.policy.crl_policy=CRLP_NONE by configuration. Also further clarify the cert_policy="none" option in documentation.
I have added the Please let me know if you want to add or change anything else. |
This is a follow-up to b665b28.
An attacker that is able to login into a token could bypass authentication by using its own certificate with any valid signature.
This change makes the default "ca, signature" with the only way to disable CA check by using "no_ca".
This, however, also makes the "none" option disabling CRL and OCSP checks only.
Resolves #80