Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete firmware rewrite #7

Merged
merged 123 commits into from
Sep 30, 2023
Merged

Complete firmware rewrite #7

merged 123 commits into from
Sep 30, 2023

Conversation

hhvrc
Copy link
Member

@hhvrc hhvrc commented Sep 29, 2023

This is a substantial rewrite of the firmware for increased code quality, better maintainability, more functionality, and to decrease coupling.

Embedded WebUI is also now in SvelteKit and uses websockets for communication.

…'em? Damn, I just yeeted on 'em. Oh damn. Damn homeboy. Damnnnn. That's a sick ass yeeeet. Damn did you just yeet on 'em? Hell yeah I just yoted on em!
This class will be used to apply visual patterns onto pins for indicating statuses
* master: (32 commits)
  Remove excess newline
  Replace last macro reference with constant String reference
  Add firmware version as constant string as well
  Reintroduce const String variable to prevent double char pointer operator+
  Update reference to .py file in platformio.ini after rename
  Attempt to improve caching of PlatformIO dependencies and build tools
  Add comments to embed_version.py
  Remove inclusion of non-existant header file
  Define SHOCKLINK_API_URL and SHOCKLINK_FW_VERSION in workflows and reference them during build
  Use built-in stringify macro helper instead
  Include string literal quotes in generated macros
  Embed fw version in firmware
  Initial test for embedding firmware version
  Create README.md
  Add missing dependency link 'needs: build' to new publish stage
  Seperate build and publish steps to get clearer CI results and remove one comment accidentally included in release notes
  Add RELEASE.md as default release body
  Make artifact URL predictable by omitting version number in file names
  Fix merge error
  Expand glob pattern to actually match semver version tags
  ...
- Made RMT Task command exchange thread safe
- Moved RMT logic to isolated class
- Abstracted logic to improve code quality
@redmushie
Copy link
Member

@hhvrc I realized today that we should just merge this into develop and have work continue there. That's kinda the whole point of the develop branch 😅

@redmushie redmushie changed the base branch from master to develop September 30, 2023 18:05
@redmushie redmushie marked this pull request as ready for review September 30, 2023 18:05
@hhvrc hhvrc merged commit 5d20f51 into develop Sep 30, 2023
@hhvrc hhvrc deleted the feature/complete-firmware-rewrite branch September 30, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants