Automatically detect type from file name #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ClemensLinnhoff <[email protected]>
jdsika
reviewed
May 28, 2024
| return "SensorView" | ||
| if filename.find("_gt_") != -1: | ||
| return "GroundTruth" | ||
| return "SensorView" |
There was a problem hiding this comment.
Maybe a logger warning here?
There was a problem hiding this comment.
There was no logger warning before when no type is set. Of course we could still add one here, but I am actually not sure, if the logger even works correctly, see #53.
Since this is blocking my development in openMSL/sl-2-0-traffic-participant-model-repository-template#12 I propose to merge without the logger entry and fix this later in #53.
jdsika
added
the
feature request
jdsika
approved these changes
May 28, 2024
jdsika
deleted the
72-auto-detect-top-level-message-type-from-trace-file-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference to a related issue in the repository
#72
Add a description
Automatically detect top-level message type from file name, if no type is specified as an input argument. The default SensorView remains, if no type is set and no type can be detected.
Mention a member
@jdsika
Check the checklist