Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return exit code 1 if warnings are given #76

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Conversation

ClemensLinnhoff
Copy link
Contributor

@ClemensLinnhoff ClemensLinnhoff commented Jun 3, 2024

Reference to a related issue in the repository

#75

Add a description

Return exit code 1 if warnings are given, so CI pipelines recognize, that osi-validation found something.

Mention a member

Add @mentions of the person or team responsible for reviewing proposed changes.

Check the checklist

  • My code and comments follow the contributors guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation for osi-validation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works. (Positive test in the pipeline when running the application)
  • New and existing unit tests / travis ci pass locally with my changes.

@ClemensLinnhoff ClemensLinnhoff linked an issue Jun 3, 2024 that may be closed by this pull request
@ClemensLinnhoff
Copy link
Contributor Author

@jdsika, of course giving an exit code will cause the pipeline to fail here. How should we handle this?

We could change the test trace file to not generate warnings. But I actually like showing this as an example. Alternatively we could catch the exit code and make the pipeline pass anyways. But then it will also pass if osi-validation crashes due to some bug.

@ClemensLinnhoff
Copy link
Contributor Author

I added a valid SensorView trace file to be tested in the CI. Now it passes.

Signed-off-by: ClemensLinnhoff <[email protected]>
@jdsika jdsika merged commit b6e642a into master Jun 5, 2024
6 checks passed
@jdsika jdsika deleted the 75-give-return-value branch June 5, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give return value
2 participants