Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files for OSM-S-219 #11

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

files for OSM-S-219 #11

wants to merge 4 commits into from

Conversation

david1597
Copy link
Contributor

No description provided.

david1597 and others added 2 commits August 17, 2017 16:47
Wouldn't this look so much better in Comic Sans
Copy link
Member

@mattodd mattodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, Ed, so I'm using the option on your commit that says "Submit feedback that must be addressed before merging." Once I submit this review, are you able to "revert" this commit, or otherwise abandon it?

@mattodd
Copy link
Member

mattodd commented Sep 6, 2017

Ok so can we try this: David re-submits the original file (before Ed's edit) and I will accept and close. I'll add a comment that says "done" (unless I change anything major) and we'll see if that comment comes up in the file list as a way to spot that this compound is ready for inclusion in the paper. Ed and I just spoke about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants