Fix(rgaa): Nav attributes and aria-current for accessibility compliance

[BarbaraOliveira13]

🎩 What?

Two parts:

1. Added dynamic aria-label attributes to navigation menus to provide better context for screen readers, improving compliance with WCAG 1.3.1 - Info and Relationships(Level A).
2. Added aria-current="true" to correctly mark active links within navigation menus, addressing WCAG 2.4.8 - Location (Level AAA).

🎩 Why?

This issue originates from an accessibility audit funded by the city of Lyon, targeting compliance with RGAA and corresponding WCAG standards. The changes ensure clearer navigation and improved usability for assistive technologies.

📌 Related Issues

• Related to: WCAG 1.3.1, 2.4.8, and RGAA 9.2/10.9.
• Fixes #?

📋 Subtasks

• Update tags to include dynamic aria-label attributes, addressing WCAG 1.3.1 - Info and Relationships.
• Add aria-current="true" to active links in navigation menus to comply with WCAG 2.4.8 - Location.
• Verify the changes comply with RGAA best practices.
• Add CHANGELOG entry
• If there's a new public field, add it to GraphQL API
• Add documentation regarding the feature
• Add/modify seeds
• Add tests
• Another subtask

📷 Screenshots (optional)

[github-actions]

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

[Quentinchampenois]

The aria-label must be translated in locales files, in English only

[Quentinchampenois]

Suggested change

	<nav role="navigation" aria-label="Sous menu - <%= translated_attribute(page.title) %>">
	<nav role="navigation" aria-label="<%= i18n.t(".navigation.aria_label", title: translated_attribute(page.title)) %>">

[Quentinchampenois]

Translation key could just be aria_label

[BarbaraOliveira13]

thanks, changes made 👍

[Quentinchampenois]

Suggested change

	<%= link_to translated_attribute(sibling.title), page_path(sibling.slug), aria_current: ("true"if page == sibling) %>
	<%= link_to translated_attribute(sibling.title), page_path(sibling.slug), aria_current: (page == sibling).to_s %>

[Quentinchampenois]

Condition in itself returns a TrueClass or FalseClass, you can use the condition return as string directly

[BarbaraOliveira13]

Indeed, thanks!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. @carolromero & @xabier feel free to chime in.