Fix wcag search filters navigation

[BarbaraOliveira13]

🎩 What?

Updated the search filters container to improve accessibility compliance. Changes include:

1. Add a <nav> element with role="navigation" to define the navigation region.
2. Add an aria-labelledby attribute referencing a hidden <h1> to programmatically name the navigation area for screen readers.

🎩 Why?

These changes address accessibility concerns highlighted during the city of Lyon rgaa audit, and align with WCAG 2.1 standards:

🔗 WCAG References:

1. 1.3.1 - Info and Relationships: Ensures information and relationships are perceivable for assistive technologies.
2. 4.1.2 - Name, Role, Value: Provides programmatically determinable names and roles for interactive elements.

🎩 Related to

In grist, array Diagnostique Decidim, line 31

📋 Subtasks

• Add CHANGELOG entry.
• If there's a new public field, add it to GraphQL API.
• Add documentation regarding the feature.
• Add/modify seeds.
• Add tests.
• Verify compliance with WCAG and visually validate changes in a local environment.

📷 Screenshots (optional)

---

[AyakorK]

The changes look great to me, well done!

I do have a small point of consideration regarding the third line of _filters.html.erb, specifically the default value. It may not be strictly necessary, but it seems like a good safeguard against potential errors.

[BarbaraOliveira13]

The changes look great to me, well done!

I do have a small point of consideration regarding the third line of _filters.html.erb, specifically the default value. It may not be strictly necessary, but it seems like a good safeguard against potential errors.

Thanks for the feedback! I agree that the default: "Search filters" parameter might not always be necessary if the key decidim.searches.filters.title is always present. Do you think it’s better to keep it as a safeguard or remove it for simplicity, @Quentinchampenois ?

[Quentinchampenois]

It's hard for me to understand changes,

The nav tag seems good with the right role and the aria-labelledby. However the value of aria-labelledby should match the ID of the currently existing H1 title (cf: 32 Results for the search: "" )

We shall not create a new h1 tag but add an ID to the existing H1 to match it

[Quentinchampenois]

I agree, the default parameter is not necessary in this case

Suggested change

	<%= t("decidim.searches.filters.title", default: "Search filters") %>
	<%= t("decidim.searches.filters.title") %>

[BarbaraOliveira13]

Good point! The changes have been implemented for better dynamic approach