Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deferred should not be final #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Deferred should not be final #7

wants to merge 1 commit into from

Commits on Jul 27, 2017

  1. Deferred should not be final 

    We use the Async Kudu Client (and I have used the Async HBase client before), and we have issues testing this in unit tests because the Deferred class is final. To mock it, we have to jump through hoops with power mock. I don't see a reason for this class to be final, so just removing the final keyword.
    @harishreedharan
    harishreedharan authored Jul 27, 2017
    Configuration menu
    Copy the full SHA
    1fd0475 View commit details
    Browse the repository at this point in the history