Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metadata reference #162

Merged
merged 8 commits into from
Mar 4, 2025
Merged

Update metadata reference #162

merged 8 commits into from
Mar 4, 2025

Conversation

Ndpnt
Copy link
Member

@Ndpnt Ndpnt commented Feb 19, 2025

No description provided.

Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for open-terms-archive-docs ready!

Name Link
🔨 Latest commit dbe1f40
🔍 Latest deploy log https://app.netlify.com/sites/open-terms-archive-docs/deploys/67c6b93f12d96d0008d1dba8
😎 Deploy Preview https://deploy-preview-162--open-terms-archive-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ndpnt Ndpnt requested a review from MattiSG February 19, 2025 16:22
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does relate to OpenTermsArchive/engine#1139? Is it generated from it?

type="array of entity objects"
description="Entity object, see [Entity](#entity) section."
type="object"
description="Map of organizations involved in the collection's governance, with organization names as keys governance object, see [Governance](#governance) section."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some words seem to be missing here 🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which ones?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not having been more explicit. I don't understand this part:

with organization names as keys governance object

{{< configOption
name="i18n"
type="object"
description="Internationalization of any of the Metadata properties (except i18n itself) for different language codes"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works but is not very clear. Maybe an example would help? 🙂

@@ -17,174 +17,187 @@ As an example, see the [complete metadata file](https://github.com/OpenTermsArch
name="id"
type="string"
description="Unique identifier derived from name (acronyms, dash-separated)."
example="`pga`"
example="pga"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we take pga as an example, which is a third-party that we don't control, instead of demo that is here to that end?

allowedValues="`host`, `administrator`, `curator`, `maintainer`, `sponsor`"
required=true
example="[host, administrator]"
required=false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not required?

@Ndpnt Ndpnt force-pushed the update-metadata-specs branch from 10c54a5 to a3b4401 Compare March 3, 2025 15:52
@Ndpnt Ndpnt requested a review from MattiSG March 3, 2025 15:54
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few additional changes, please double check before merging 🙂

@Ndpnt Ndpnt merged commit d45eb41 into main Mar 4, 2025
5 checks passed
@Ndpnt Ndpnt deleted the update-metadata-specs branch March 4, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants