-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metadata reference #162
Conversation
✅ Deploy Preview for open-terms-archive-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does relate to OpenTermsArchive/engine#1139? Is it generated from it?
type="array of entity objects" | ||
description="Entity object, see [Entity](#entity) section." | ||
type="object" | ||
description="Map of organizations involved in the collection's governance, with organization names as keys governance object, see [Governance](#governance) section." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some words seem to be missing here 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not having been more explicit. I don't understand this part:
with organization names as keys governance object
{{< configOption | ||
name="i18n" | ||
type="object" | ||
description="Internationalization of any of the Metadata properties (except i18n itself) for different language codes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works but is not very clear. Maybe an example would help? 🙂
@@ -17,174 +17,187 @@ As an example, see the [complete metadata file](https://github.com/OpenTermsArch | |||
name="id" | |||
type="string" | |||
description="Unique identifier derived from name (acronyms, dash-separated)." | |||
example="`pga`" | |||
example="pga" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we take pga
as an example, which is a third-party that we don't control, instead of demo
that is here to that end?
allowedValues="`host`, `administrator`, `curator`, `maintainer`, `sponsor`" | ||
required=true | ||
example="[host, administrator]" | ||
required=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this not required?
10c54a5
to
a3b4401
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few additional changes, please double check before merging 🙂
No description provided.