Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added BCH Guru wave2 metadata #11

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

bchguru
Copy link
Contributor

@bchguru bchguru commented Sep 25, 2023

Added metadata snapshot for BCH Guru to include wave 2 NFT metadata as discussed in issue #10 .

This metadata is also the current authHead for the BCHGURU identity (txid 0e273099d062afb45afad0289f6740232ab3ae864e20534e44cf5201d315c30b)

@bitjson
Copy link
Member

bitjson commented Sep 25, 2023

Reviewed, looks great, thanks for the careful work @bchguru! This PR also doesn't need another reviewer – @bchguru is a previous contributor, so I was the second review. Merging 🚀

I'll note there are a few minimal changes to existing extensions.attributes, e.g.

"extensions": {
                    "attributes": {
-                     "Background": "Lime Burst Gradient",
+                     "Background": "Lime Burst",
// ...

I verified that those changes exist in the on-chain metadata too.

By the way @bchguru, I just invited you to the Reviewer team here on the GitHub.

(Repo note: this PR follows discussion initiated by @bchguru about OTR's policy for historical metadata: #10)

@bitjson bitjson merged commit 705cfd8 into OpenTokenRegistry:master Sep 25, 2023
1 check passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants