Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect upper bound of RTP payload validity check (#946) #947

Conversation

hogliux
Copy link
Contributor

@hogliux hogliux commented Aug 13, 2024

This PR fixes #946 by fixing the upper limits of the conditional in lib/src/mt_util.h:92 and app/src/parse_json.c:467.

@Sakoram
Copy link
Collaborator

Sakoram commented Aug 19, 2024

Due to temporary infrastructure problems, I ran the unit tests locally. They passed successfully:

Running test: ===========================================
./build/tests/KahawaiUfdTest --p_port 0000:4b:01.1 --r_port 0000:4b:01.2

Test passed in 17 seconds.

===========================================
Running test: ===========================================
./build/tests/KahawaiUfdTest --p_port 0000:4b:01.1 --r_port 0000:4b:01.2 --queue_mode shared

Test passed in 18 seconds.

===========================================
Running test: ===========================================
./build/tests/KahawaiUfdTest --p_port 0000:4b:01.1 --r_port 0000:4b:01.2 --queue_mode shared --udp_lcore

Test passed in 19 seconds.

===========================================
Running test: ===========================================
./build/tests/KahawaiUfdTest --p_port 0000:4b:01.1 --r_port 0000:4b:01.2 --rss_mode l3_l4

Test passed in 18 seconds.

===========================================
Running test: ===========================================
./build/tests/KahawaiTest --auto_start_stop --p_port 0000:4b:01.1 --r_port 0000:4b:01.2 --dma_dev 0000:00:01.0,0000:00:01.1 --gtest_filter=-St22_?x.*

Test passed in 786 seconds.

===========================================
Running test: ===========================================
./build/tests/KahawaiTest --auto_start_stop --p_port 0000:4b:01.1 --r_port 0000:4b:01.2 --rss_mode l3_l4 --pacing_way tsc --iova_mode pa --multi_src_port --gtest_filter=Main.:St20p:-ext

Test passed in 80 seconds.

===========================================
Running test: ===========================================
./build/tests/KahawaiTest --p_port kernel:lo --r_port kernel:lo --auto_start_stop --gtest_filter=St20p*

Test passed in 138 seconds.

===========================================

@Sakoram Sakoram merged commit 26af5a3 into OpenVisualCloud:main Aug 19, 2024
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intel MTL rejects valid RTP payload type of 127
2 participants