Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ignore the fifo_size parameter in the st30p tx pipeline api (#948) #949

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

hogliux
Copy link
Contributor

@hogliux hogliux commented Aug 15, 2024

The st30p pipeline API allows the user to specify the fifo_size parameter. Unfortunately, the parameter is ignored and not used anywhere in the codebase. This parameter is critical for achieving low latency audio streams.

See issue #948

@Sakoram
Copy link
Collaborator

Sakoram commented Aug 21, 2024

Again, due to temporary infrastructure problems, I ran the unit tests locally. They passed successfully:
Running test: ===========================================
./build/tests/KahawaiUfdTest --p_port 0000:4b:01.1 --r_port 0000:4b:01.2

Test passed in 16 seconds.

===========================================
Running test: ===========================================
./build/tests/KahawaiUfdTest --p_port 0000:4b:01.1 --r_port 0000:4b:01.2 --queue_mode shared

Test passed in 20 seconds.

===========================================
Running test: ===========================================
./build/tests/KahawaiUfdTest --p_port 0000:4b:01.1 --r_port 0000:4b:01.2 --queue_mode shared --udp_lcore

Test passed in 20 seconds.

===========================================
Running test: ===========================================
./build/tests/KahawaiUfdTest --p_port 0000:4b:01.1 --r_port 0000:4b:01.2 --rss_mode l3_l4

Test passed in 18 seconds.

===========================================
Running test: ===========================================
./build/tests/KahawaiTest --auto_start_stop --p_port 0000:4b:01.1 --r_port 0000:4b:01.2 --dma_dev 0000:00:01.0,0000:00:01.1 --gtest_filter=-St22_?x.*

Test passed in 776 seconds.

===========================================
Running test: ===========================================
./build/tests/KahawaiTest --auto_start_stop --p_port 0000:4b:01.1 --r_port 0000:4b:01.2 --rss_mode l3_l4 --pacing_way tsc --iova_mode pa --multi_src_port --gtest_filter=Main.:St20p:-ext

Test passed in 81 seconds.

===========================================
Running test: ===========================================
./build/tests/KahawaiTest --p_port kernel:lo --r_port kernel:lo --auto_start_stop --gtest_filter=St20p*

Test passed in 138 seconds.

===========================================

Copy link
Collaborator

@PanKaker PanKaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Looks good to me

@PanKaker PanKaker merged commit 1d87e7e into OpenVisualCloud:main Aug 21, 2024
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants