Update ca/crl last_update on HTTP 304 so refresh intervals are respected (#435)#440
Open
SAY-5 wants to merge 1 commit into
Open
Update ca/crl last_update on HTTP 304 so refresh intervals are respected (#435)#440SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
A 304 Not Modified response confirms the local CA certificate or CRL is current, so the refresh-interval TTL should be reset. Previously ca_last_update (backed by ca.pem's mtime) never advanced past the initial download in steady state, so every agent run saw a stale mtime and re-issued the conditional GET regardless of ca_refresh_interval. The CRL path had the same structural issue but was latent because CRL endpoints typically respond 200 often enough that save_crls bumps the mtime naturally. Fix it for symmetry. Fixes OpenVoxProject#435 Signed-off-by: SAY-5 <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #435.
When the CA endpoint responds 304 Not Modified,
refresh_capreviously logged "CA certificate is unmodified" but never resetca_last_update. Since that timestamp is backed by the mtime ofca.pem, and the mtime is only bumped on the 200 path throughsave_cacerts, in steady state (where 304 is the typical response) the mtime stayed pinned to the initial download. As a resultneeds_refresh?evaluated to true on every agent run, and the agent issued a conditional GET to the CA every cycle regardless of the configuredca_refresh_interval.refresh_crlhas the same structural issue but is latent in practice because CRL endpoints return 200 often enough thatsave_crlsbumps the mtime naturally. Fixed for symmetry.Reproduction (from the issue):
Prior behavior: logs print on every run. With this patch: logs print at the configured
ca_refresh_interval(default 24h).Regression tests added:
updates the `last_update` time on 304 Not Modified so ca_refresh_interval is respectedupdates the `last_update` time on 304 Not Modified so crl_refresh_interval is respectedBoth fail without the patch and pass with it. Full
spec/unit/ssl/state_machine_spec.rbis green (99 examples).