fix(windows): resolve llama-server with where.exe without shell#1228
Open
stantheman0128 wants to merge 1 commit into
Open
fix(windows): resolve llama-server with where.exe without shell#1228stantheman0128 wants to merge 1 commit into
stantheman0128 wants to merge 1 commit into
Conversation
Avoid cmd.exe shell:true PATH lookup and trim CRLF from where.exe stdout so system binary detection works reliably on Windows. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getSystemBinaryPathusedwherewithshell: true, which routes through cmd.exe and is fragile for PATH lookup.where.exewithshell: falseandwindowsHide: true./\r?\n/so CRLF from where.exe does not leave a trailing CR on the first path.AI assistance
This PR was prepared with AI assistance (Cursor/Grok). Human author: Stan Shih (@stantheman0128). Please review carefully.
Verification / Evidence
Live Windows 11 smoke (where.exe + shell: false):
npm run typecheck(pass)npm run lint(pass)