fix(windows): quote Expand-Archive paths for apostrophes#1231
Open
stantheman0128 wants to merge 1 commit into
Open
fix(windows): quote Expand-Archive paths for apostrophes#1231stantheman0128 wants to merge 1 commit into
stantheman0128 wants to merge 1 commit into
Conversation
PowerShell single-quoted -Path embedding broke zip extract when the user profile path contained an apostrophe. Use -LiteralPath with doubled apostrophes via powershell.exe. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows,
extractZipWindowsfell back to PowerShellExpand-Archivewith paths embedded in single quotes via-Path. Paths containing an apostrophe (for exampleC:\Users\O'Brien\...) break that command, so binary/model zip extraction fails after tar fallback.This switches to
powershell.exewith-LiteralPathand doubles apostrophes for PowerShell single-quoted strings.AI assistance
Assisted by Cursor / Grok. Human author: Stan Shih (stantheman0128). I reviewed the diff and verification output.
Verification / Evidence
Test plan