feat(audio): add native macOS system audio tap#485
Merged
Conversation
Add a Swift CoreAudio tap helper and main-process manager for native macOS system audio capture in meeting transcription. Keep native system audio in main, preserve the legacy Electron flow as fallback, and align the Electron bridge typings with the shipped preload APIs so lint and typecheck pass on the feature branch.
Remove the remaining screen-capture loopback path and delete unused\nsystem-audio helpers so meeting transcription relies on the native\naudio tap manager only.\n\nHide system-audio permission UI when native capture is unsupported\nand simplify meeting startup to warm only the streams that can\nreceive audio.
…t OS on mount Microphone permission was persisted in localStorage and never re-checked against the actual OS state, causing stale "granted" status after TCC resets or app updates. System audio request was using a probe-based approach instead of the read-only getMediaAccessStatus API. - Add check-microphone-access IPC handler using getMediaAccessStatus - Add mount-time re-validation effect for mic permission in usePermissions - Replace probe-based system audio request with getMediaAccessStatus + open Settings - Expand SystemAudioAccessResult status type to include all OS return values
Add strict format rules to BASE_SYSTEM_PROMPT to prevent tables, preamble, attendee lists, and horizontal rules in generated notes. Generate titles for all notes after action processing, not just meeting notes. Forward title parameter through onSuccess callback.
charian47
pushed a commit
to charian47/openwhispr
that referenced
this pull request
Apr 25, 2026
feat(audio): add native macOS system audio tap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
macos-audio-taphelper and build/package wiring for CoreAudio tap captureValidation
npx prettier --write ...npm run lint(passes with existing repo warnings only)npm run typecheckNotes
getDisplayMediafallback