refactor: release cleanup for v1.6.6#489
Merged
Merged
Conversation
- Remove dead code: optimizeAudio/audioBufferToWav (audioManager), preferUinput branch (clipboard), prevMeetingRecRef (NoteEditor), closeResolve (openaiRealtimeStreaming), unused onSelect/onBlur props (RichTextEditor), dead platform/isMacOS vars (OnboardingFlow), redundant prefers-reduced-motion block (index.css) - Fix safety issues: guard onStopMeetingRecording with nullish coalescing, add try/catch to useSystemAudioPermission.request(), close db before file deletion in database.cleanup(), reset _meetingModeActive on error in meetingDetectionEngine - Add 28+ missing translation keys across all 9 non-English locales (history context menu, floating icon position, audio retention), plus new keys for backToNotes, speaker labels, wayland paste, and systemSettings.systemAudio - Fix hardcoded strings: "Back to notes" and "You"/"Them" speaker labels now use t() translations - Extract shared utilities: validateHotkeyForSlot (replaces 3 duplicate validators), parseTranscriptSegments (replaces 2 duplicate parsers) - Clean up ipcHandlers: hoist systemPreferences import, move streaming state init to constructor, simplify pairs construction, expand compressed try/catch, add systemAudio to settings messages - Fix type safety: update cloudReason type to include systemPrompt, promptMode, matchType; remove (window as any) cast in ReasoningService; replace console.error with logger in usePermissions; add null guard for process.resourcesPath in clipboard; pass provider to invalidateApiKeyCaches in settingsStore - Simplify hooks: remove redundant wrapper functions in useAudioRecording, inline single-element array loops in useMeetingTranscription, remove unused params from areRequiredPermissionsMet - Add React type import in PermissionsGate
charian47
pushed a commit
to charian47/openwhispr
that referenced
this pull request
Apr 25, 2026
…ase-cleanup refactor: release cleanup for v1.6.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove dead code: optimizeAudio/audioBufferToWav (audioManager), preferUinput branch (clipboard), prevMeetingRecRef (NoteEditor), closeResolve (openaiRealtimeStreaming), unused onSelect/onBlur props (RichTextEditor), dead platform/isMacOS vars (OnboardingFlow), redundant prefers-reduced-motion block (index.css)
Fix safety issues: guard onStopMeetingRecording with nullish coalescing, add try/catch to useSystemAudioPermission.request(), close db before file deletion in database.cleanup(), reset _meetingModeActive on error in meetingDetectionEngine
Add 28+ missing translation keys across all 9 non-English locales (history context menu, floating icon position, audio retention), plus new keys for backToNotes, speaker labels, wayland paste, and systemSettings.systemAudio
Fix hardcoded strings: "Back to notes" and "You"/"Them" speaker labels now use t() translations
Extract shared utilities: validateHotkeyForSlot (replaces 3 duplicate validators), parseTranscriptSegments (replaces 2 duplicate parsers)
Clean up ipcHandlers: hoist systemPreferences import, move streaming state init to constructor, simplify pairs construction, expand compressed try/catch, add systemAudio to settings messages
Fix type safety: update cloudReason type to include systemPrompt, promptMode, matchType; remove (window as any) cast in ReasoningService; replace console.error with logger in usePermissions; add null guard for process.resourcesPath in clipboard; pass provider to invalidateApiKeyCaches in settingsStore
Simplify hooks: remove redundant wrapper functions in useAudioRecording, inline single-element array loops in useMeetingTranscription, remove unused params from areRequiredPermissionsMet
Add React type import in PermissionsGate