Skip to content

Conversation

@emnul
Copy link
Contributor

@emnul emnul commented Oct 29, 2025

Removes

  • @tsconfig/node22 from @openzeppelin-compact/contracts, @openzeppelin-compact/compact, @openzeppelin-compact/contracts-simulator

Adds

  • @tsconfig/node24 to @openzeppelin-compact/contracts, @openzeppelin-compact/compact, @openzeppelin-compact/contracts-simulator

Changes

  • node version requirement to >=22 in @openzeppelin-compact/contracts-simulator and @openzeppelin-compact/contracts
  • Upgrade @types/node 22.18.0 -> 24.9.0 in openzeppelin-compact, @openzeppelin-compact/contracts, @openzeppelin-compact/compact, @openzeppelin-compact/contracts-simulator
  • Bump .nvmrc to v24.9.0

Closes #277

Summary by CodeRabbit

  • Chores
    • Updated Node.js runtime to v24.9.0
    • Updated Node.js type definitions and TypeScript configurations
    • Updated minimum required Node.js version to v22 for development and runtime
    • Updated development tooling dependencies

@emnul emnul requested a review from a team as a code owner October 29, 2025 21:42
Copy link
Member

@0xisk 0xisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: ⟣ €₥ℵ∪ℓ ⟢ <[email protected]>
@coderabbitai
Copy link

coderabbitai bot commented Nov 3, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This pull request systematically upgrades Node.js tooling across the monorepo. Updates include bumping the .nvmrc version from v22.18.0 to v24.9.0, replacing @tsconfig/node22 with @tsconfig/node24, updating @types/node to version 24.9.0 across multiple packages, and adjusting engine requirements in package.json files.

Changes

Cohort / File(s) Summary
Environment and Documentation
.nvmrc, CHANGELOG.md
Updated Node.js version reference from v22.18.0 to v24.9.0; documented version bump and tooling changes.
Root Dependencies
package.json
Upgraded @types/node devDependency from 22.18.0 to 24.9.0.
Contracts Package
contracts/package.json, contracts/tsconfig.json
Added engines.node = ">=22", replaced @tsconfig/node22 with @tsconfig/node24, updated @types/node to 24.x; updated TypeScript configuration extends target.
Compact Package
packages/compact/package.json, packages/compact/tsconfig.json
Replaced @tsconfig/node22 with @tsconfig/node24, updated @types/node from 22.18.0 to 24.9.0; updated TypeScript configuration extends target.
Simulator Package
packages/simulator/package.json, packages/simulator/tsconfig.json
Updated engines.node from ">=18" to ">=22", replaced @tsconfig/node22 with @tsconfig/node24, updated @types/node to 24.9.0; updated TypeScript configuration extends target and reformatted include/exclude arrays.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify all references to @tsconfig/node22 have been replaced with @tsconfig/node24 across all package configurations
  • Confirm @types/node version is consistently set to 24.9.0 or 24.9.2 across the monorepo
  • Check that engine requirement changes (contracts and simulator packages) are intentional and appropriate for downstream consumers
  • Validate CHANGELOG.md accurately reflects all version updates and package modifications

Poem

🐰 From twenty-two to twenty-four we hop,
With tsconfigs updated, the versions don't stop!
Node types reimagined, a fresh TypeScript breeze,
The engines now humming a new-versioned tease,
Our monorepo's upgraded—hooray and huzzah! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Migrate to Node24' clearly and accurately summarizes the main change: upgrading the project to Node.js version 24.
Linked Issues check ✅ Passed The PR successfully upgrades @types/node from 22.18.0 to 24.9.0 (slightly below the 24.9.2 target) and includes associated Node24 ecosystem updates as expected.
Out of Scope Changes check ✅ Passed The PR contains only in-scope changes: @tsconfig/node22 replacement, @types/node updates, .nvmrc bump, and engine requirement changes are all necessary for the Node24 migration.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@0xisk 0xisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

Signed-off-by: ⟣ €₥ℵ∪ℓ ⟢ <[email protected]>
Copy link
Member

@0xisk 0xisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dejavu :)

@emnul emnul merged commit e3a786f into main Nov 4, 2025
8 checks passed
@emnul emnul deleted the migrate-to-node24 branch November 4, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants