-
Notifications
You must be signed in to change notification settings - Fork 14
fix(gh-actions): release PR requisted changes #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <[email protected]> Signed-off-by: Andrew Fleming <[email protected]>
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughEstablishes release infrastructure by introducing new CI workflows for version bumping and npm publishing, centralizing Compact compiler setup in a composite action, refactoring the build pipeline to a four-step process, and adding public package metadata to enable distribution while documenting the complete release workflow. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GitHub as GitHub Actions
participant Installer as Compact Installer
participant npm as npm Registry
rect rgb(200, 220, 240)
Note over User,GitHub: Prepare Release Phase
User->>GitHub: Push release branch (release-v*)
GitHub->>GitHub: prepare-release workflow triggers
GitHub->>GitHub: Extract version from branch name
GitHub->>GitHub: Update contracts/package.json
GitHub->>GitHub: Replace version strings in codebase
GitHub->>GitHub: Auto-commit changes
end
rect rgb(240, 220, 200)
Note over User,GitHub: Version Validation & Setup
User->>GitHub: Create release tag & publish
GitHub->>GitHub: release workflow triggers
GitHub->>GitHub: Build contracts
GitHub->>GitHub: Validate tag vs package.json version
end
rect rgb(220, 240, 200)
Note over GitHub,npm: Publishing Phase
GitHub->>GitHub: Pack tarball from contracts/dist
GitHub->>GitHub: Compute npm dist-tag (latest/beta/next)
GitHub->>GitHub: Verify tarball (no private field)
GitHub->>npm: Publish tarball with tag & provenance
npm-->>GitHub: Package published
GitHub->>User: Log success with install instructions
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes
Areas requiring extra attention:
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
Comment |
Signed-off-by: ⟣ €₥ℵ∪ℓ ⟢ <[email protected]>
Signed-off-by: ⟣ €₥ℵ∪ℓ ⟢ <[email protected]>
Signed-off-by: ⟣ €₥ℵ∪ℓ ⟢ <[email protected]>
emnul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know what you think about the changes:
- Updated references to Compact 0.26.0
- Updated actions to latest versions
- Updated runner to use pinned version
As well as the proposed change to prerelease.yml
Signed-off-by: ⟣ €₥ℵ∪ℓ ⟢ <[email protected]>
Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <[email protected]> Signed-off-by: 0xisk <[email protected]>
Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <[email protected]> Signed-off-by: 0xisk <[email protected]>
|
Thank you for your contributions @0xisk ! |
Types of changes
What types of changes does your code introduce to OpenZeppelin Midnight Contracts?
Put an
xin the boxes that applyFixes #212 #268
PR Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
Summary by CodeRabbit
New Features
Documentation
Chores