fix: fix bitwise shift precedence in ANIMAL_MASK
and related logic
#778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an issue with the bitwise shift operations in the
ANIMAL_MASK
constant and a similar line in thesetAnimalAndSpin
function. The expression160 + 16
was being evaluated first due to operator precedence, resulting in an unintended shift of 176 bits instead of the intended 160 + 16 bits.I’ve fixed this by adding parentheses to ensure the correct order of operations. This ensures that the mask and related logic work as intended, preventing potential issues with data extraction and storage in the
carousel
mapping.Changes:
ANIMAL_MASK
to use parentheses:setAnimalAndSpin
:This should resolve the issue and ensure the contract behaves as expected.