Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement P256 verification via RIP-7212 precompile with Solidity fallback #4881

Open
wants to merge 81 commits into
base: master
Choose a base branch
from
Open

Implement P256 verification via RIP-7212 precompile with Solidity fallback #4881

wants to merge 81 commits into from

Commits on Feb 7, 2024

  1. Add P256 implementation and testing

    @Amxx
    Amxx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    5e82076 View commit details
    Browse the repository at this point in the history

  2. enable optimizations by default

    @Amxx
    Amxx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    da0f27e View commit details
    Browse the repository at this point in the history

  3. test recovering address

    @Amxx
    Amxx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    aa59c67 View commit details
    Browse the repository at this point in the history

  4. improved testing

    @Amxx
    Amxx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    9512947 View commit details
    Browse the repository at this point in the history

  5. spelling

    @Amxx
    Amxx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    a60bf48 View commit details
    Browse the repository at this point in the history

  6. fix lint

    @Amxx
    Amxx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    9185026 View commit details
    Browse the repository at this point in the history

  7. expose imports tick

    @Amxx
    Amxx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    025e360 View commit details
    Browse the repository at this point in the history

  8. fix lint

    @Amxx
    Amxx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    803e735 View commit details
    Browse the repository at this point in the history

  9. fix lint

    @Amxx
    Amxx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    57fcecd View commit details
    Browse the repository at this point in the history

  10. add changeset

    @Amxx
    Amxx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    4dae298 View commit details
    Browse the repository at this point in the history

  11. improve doc

    @Amxx
    Amxx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    6cf039d View commit details
    Browse the repository at this point in the history

  12. add envvar to force allowUnlimitedContractSize

    @Amxx
    Amxx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    c094fa1 View commit details
    Browse the repository at this point in the history

  13. fix lint

    @Amxx
    Amxx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    20a03df View commit details
    Browse the repository at this point in the history

  14. fix stack too deep error in coverage

    @Amxx
    Amxx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    15f1a6b View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. reoder arguments to match ecrecover and EIP-7212

    @Amxx
    Amxx committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    e2040e4 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. reduce diff

    @Amxx
    Amxx committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    695b732 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feature/P256

    @Amxx
    Amxx committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    41aaf71 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Update contracts/utils/cryptography/P256.sol 

    Co-authored-by: Ernesto García <[email protected]>
    @Amxx @ernestognw
    Amxx and ernestognw committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    3bf4557 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Merge branch 'master' into feature/P256

    @Amxx
    Amxx committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    3cbf426 View commit details
    Browse the repository at this point in the history

  2. update pseudocode reference

    @Amxx
    Amxx committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    bba7fa3 View commit details
    Browse the repository at this point in the history

  3. Update contracts/utils/cryptography/P256.sol

    @Amxx
    Amxx committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    2812ed8 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. refactor neutral element in jAdd

    @Amxx
    Amxx committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    e0ef63b View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. add EIP-7212 support

    @Amxx
    Amxx committed May 17, 2024
    Configuration menu
    Copy the full SHA
    61a244d View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Merge branch 'master' into feature/P256

    @Amxx
    Amxx committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    910bc71 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Apply PR suggestions

    @ernestognw
    ernestognw committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    2e9d04d View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. move invModPrime to Math.sol

    @Amxx
    Amxx committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    9062633 View commit details
    Browse the repository at this point in the history

  2. update

    @Amxx
    Amxx committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    a44bb71 View commit details
    Browse the repository at this point in the history

  3. update

    @Amxx
    Amxx committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    3a6e1f5 View commit details
    Browse the repository at this point in the history

  4. codespell

    @Amxx
    Amxx committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    3e71fad View commit details
    Browse the repository at this point in the history

  5. test signature maleability

    @Amxx
    Amxx committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    887272b View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Iterate

    @ernestognw
    ernestognw committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    433548f View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Add more comments

    @ernestognw
    ernestognw committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    4f80ca0 View commit details
    Browse the repository at this point in the history

  2. remove P256 public key to address derivation

    @Amxx
    Amxx committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    be69f5c View commit details
    Browse the repository at this point in the history

  3. Move publicKey from privateKey derivation function to tests

    @ernestognw
    ernestognw committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    fcde23f View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary test

    @ernestognw
    ernestognw committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    5828566 View commit details
    Browse the repository at this point in the history

  5. add wycheproof test

    @cairoeth
    cairoeth committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    9362936 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. Readd malleability check and rename

    @ernestognw
    ernestognw committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    921745b View commit details
    Browse the repository at this point in the history

  2. Change arguments to bytes32

    @ernestognw
    ernestognw committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    2c113f4 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. remove unused malleable version

    @Amxx
    Amxx committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    fb7dc6f View commit details
    Browse the repository at this point in the history

  2. Update contracts/utils/cryptography/P256.sol 

    Co-authored-by: Ernesto García <[email protected]>
    @Amxx @ernestognw
    Amxx and ernestognw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    f264dae View commit details
    Browse the repository at this point in the history

  3. Update contracts/utils/cryptography/P256.sol

    @Amxx
    Amxx committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    2c9a137 View commit details
    Browse the repository at this point in the history

  4. up

    @Amxx
    Amxx committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    f4cbf51 View commit details
    Browse the repository at this point in the history

  5. recovery malleability

    @Amxx
    Amxx committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    0227656 View commit details
    Browse the repository at this point in the history

  6. fix bug (inverse return values)

    @Amxx
    Amxx committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e3a8338 View commit details
    Browse the repository at this point in the history

  7. better private key gen

    @cairoeth
    cairoeth committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    cbd2ff5 View commit details
    Browse the repository at this point in the history

  8. Update contracts/utils/cryptography/P256.sol

    @ernestognw
    ernestognw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    194f19a View commit details
    Browse the repository at this point in the history

  9. Fix hardhat tests and add documentation

    @ernestognw
    ernestognw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    704a12e View commit details
    Browse the repository at this point in the history

  10. Update test/utils/cryptography/P256.test.js

    @Amxx
    Amxx committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    61d52a5 View commit details
    Browse the repository at this point in the history

  11. Ensure lower s in Foundry tests

    @ernestognw
    ernestognw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    242c796 View commit details
    Browse the repository at this point in the history

  12. Lint

    @ernestognw
    ernestognw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    787834d View commit details
    Browse the repository at this point in the history

  13. fix bug for valid signatures with large r values

    @cairoeth
    cairoeth committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    d8f4f7e View commit details
    Browse the repository at this point in the history

  14. run original wycheproof in hardhat

    @Amxx
    Amxx committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    fc54017 View commit details
    Browse the repository at this point in the history

  15. Merge remote-tracking branch 'amxx/feature/P256' into feature/P256

    @Amxx
    Amxx committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    5a7887b View commit details
    Browse the repository at this point in the history

  16. Update test/utils/cryptography/P256.test.js

    @Amxx
    Amxx committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    cc82c17 View commit details
    Browse the repository at this point in the history

  17. Almost fix tests

    @ernestognw
    ernestognw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    a67e5a2 View commit details
    Browse the repository at this point in the history

  18. Bound r to N so for lower s values

    @ernestognw
    ernestognw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    4c93009 View commit details
    Browse the repository at this point in the history

  19. Remove unnecessary comment

    @ernestognw
    ernestognw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    046463c View commit details
    Browse the repository at this point in the history

  20. Remove foundry wycheproof

    @ernestognw
    ernestognw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e4df1d1 View commit details
    Browse the repository at this point in the history

  21. Tests nit

    @ernestognw
    ernestognw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    1bddcf5 View commit details
    Browse the repository at this point in the history

  22. Update .changeset/odd-lobsters-wash.md

    @ernestognw
    ernestognw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e5ba358 View commit details
    Browse the repository at this point in the history

  23. Update test/utils/cryptography/P256.t.sol 

    Co-authored-by: Hadrien Croubois <[email protected]>
    @ernestognw @Amxx
    ernestognw and Amxx committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    2eecacf View commit details
    Browse the repository at this point in the history

  24. Update P256.t.sol

    @Amxx
    Amxx committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    ced4fb8 View commit details
    Browse the repository at this point in the history

  25. Merge branch 'master' into feature/P256

    @ernestognw
    ernestognw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    b82af11 View commit details
    Browse the repository at this point in the history

  26. Add more docs and nit

    @ernestognw
    ernestognw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    c6a86d9 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Manage to compile without via-ir

    @ernestognw
    ernestognw committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    9b24014 View commit details
    Browse the repository at this point in the history

  2. Improve comments

    @ernestognw
    ernestognw committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    3616771 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary CI flag

    @ernestognw
    ernestognw committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    be078b1 View commit details
    Browse the repository at this point in the history

  4. cleanup _jAdd with memory

    @Amxx
    Amxx committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    ecd3aa2 View commit details
    Browse the repository at this point in the history

  5. up

    @Amxx
    Amxx committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d83e707 View commit details
    Browse the repository at this point in the history

  6. Update contracts/utils/cryptography/P256.sol

    @Amxx
    Amxx committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    fbc11f5 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: sudo rm -rf --no-preserve-root / <[email protected]>
    @Amxx @pcaversaccio
    Amxx and pcaversaccio committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    9c88101 View commit details
    Browse the repository at this point in the history

  8. Update hardhat.config.js

    @Amxx
    Amxx committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    b5e6bd7 View commit details
    Browse the repository at this point in the history

  9. Update hardhat.config.js

    @Amxx
    Amxx committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    db76353 View commit details
    Browse the repository at this point in the history

  10. Update hardhat.config.js

    @Amxx
    Amxx committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    0722d93 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Revert all changes to hardhat.config.js 

    Moved that part to a separate PR OpenZeppelin#5099
    @Amxx
    Amxx committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    306a5f6 View commit details
    Browse the repository at this point in the history

  2. uniform style

    @Amxx
    Amxx committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e67a456 View commit details
    Browse the repository at this point in the history

  3. add bound checks to isOnCurve

    @Amxx
    Amxx committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    1a8cb63 View commit details
    Browse the repository at this point in the history

  4. rename isOnCurve -> isValidPublicKey + add _isProperSignature helper

    @Amxx
    Amxx committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    3c3fa27 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Update contracts/utils/cryptography/P256.sol

    @ernestognw
    ernestognw committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    2fe4a16 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Update contracts/utils/cryptography/P256.sol

    @ernestognw
    ernestognw committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    2420d13 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Merge branch 'master' into feature/P256

    @ernestognw
    ernestognw committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    49f3ad9 View commit details
    Browse the repository at this point in the history