Skip to content

chore(deps): Fix vulnerabilites #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+30 −16
Open

chore(deps): Fix vulnerabilites #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions osv-scanner.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
[[IgnoredVulns]]
id = "RUSTSEC-2021-0141"
reason = "The crate is unmaintained, but it works. If there is any new vulnerability, there will be another ID."

[[IgnoredVulns]]
id = "RUSTSEC-2024-0375"
reason = "The crate is unmaintained, but it works. If there is any new vulnerability, there will be another ID."

[[IgnoredVulns]]
id = "RUSTSEC-2024-0388"
reason = "The crate is unmaintained, but it works. If there is any new vulnerability, there will be another ID."

[[IgnoredVulns]]
id = "RUSTSEC-2024-0436"
reason = "The crate is unmaintained, but it works. If there is any new vulnerability, there will be another ID."
3 changes: 2 additions & 1 deletion plugins/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,6 @@
"jest": "^29.7.0",
"ts-jest": "^29.1.2",
"typescript": "^5.3.3"
}
},
"packageManager": "[email protected]+sha512.37ebf1a5c7a30d5fabe0c5df44ee8da4c965ca0c5af3dbab28c3a1681b70a256218d05c81c9c0dcf767ef6b8551eb5b960042b9ed4300c59242336377e01cfad"
}
27 changes: 12 additions & 15 deletions plugins/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions plugins/pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we also add minimumReleaseAge to not be that vulnerable to supply chain attacks. 1440 seems like a good value, which is 24h.
https://pnpm.io/settings#minimumreleaseage

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I've looked into it, I'm gonna work on a plan to harden supply chain security across our repos, including settings like this.

overrides:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of using overrides because they're often forgotten. What we should do is add comments explaining why we're adding these overrides, like which dependencies require them. That way, once those dependencies are updated, we can remove the overrides.

axios@<1.12.0: '>=1.12.0'
tmp@<=0.2.3: '>=0.2.4'