Skip to content

chore: Force run of docker-scan #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Force run of docker-scan #504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ jobs:
- changed_files
- ci
if: |
${{ github.event.pull_request.draft == false && needs.changed_files.outputs.changed-docker-files == 'true' }}
${{ always() && github.event.pull_request.draft == false && needs.changed_files.outputs.changed-docker-files == 'true' && needs.ci.result == 'success' }}
Copy link

@coderabbitai coderabbitai bot Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Condition still blocks docker-scan when ci is skipped

The new guard still requires needs.ci.result == 'success'. When ci is skipped (the scenario called out in the PR description), its result is 'skipped', so this expression evaluates to false and the job is skipped again. The added always() never gets to help. To actually force the scan when ci doesn’t run, allow 'skipped' as an acceptable result (e.g. in(['success','skipped'], needs.ci.result)) or drop the equality altogether.

🤖 Prompt for AI Agents 
.github/workflows/ci.yaml around line 291: the job’s if condition still requires
needs.ci.result == 'success', so when the CI job is skipped the expression is
false and docker-scan is skipped; update the condition to allow a skipped CI by
replacing that equality with a membership check (e.g. in(['success','skipped'],
needs.ci.result)) or remove the needs.ci.result check entirely so docker-scan
runs when changed-docker-files is true and the other guards pass.

steps:
# Checkout the repository
- name: Harden the runner (Audit all outbound calls)
Expand Down