ref: add associated error types for contract traits #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for contracts-stylus canceled.
|
qalisander
commented
Aug 20, 2024
| @@ -60,18 +60,6 @@ pub enum Error { | |||
| ECDSA(ecdsa::Error), | |||
| } | |||
|
|
|||
| impl MethodError for erc20::Error { | |||
There was a problem hiding this comment.
MethodError implementation is moved to the corresponding contract
There was a problem hiding this comment.
This means that this import can be removed from this file, right?
bidzyyys
reviewed
Aug 20, 2024
bidzyyys
reviewed
Aug 20, 2024
qalisander
force-pushed
the
error-associated-type-for-contract-traits
branch
from
42f0502 to
bd9049e
Compare
alexfertel
suggested changes
Aug 21, 2024
| @@ -60,18 +60,6 @@ pub enum Error { | |||
| ECDSA(ecdsa::Error), | |||
| } | |||
|
|
|||
| impl MethodError for erc20::Error { | |||
There was a problem hiding this comment.
This means that this import can be removed from this file, right?
alexfertel
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to the library users to reuse our traits with their own error types.
And it is more "rusty" approach having associated error types for traits with fallible functions.
Adds new functional macro for the
MethodErrortrait.