fix(builder): add adapter package aliases to vitest config #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The export tests were failing because Vitest couldn't resolve the adapter packages (@openzeppelin/ui-builder-adapter-*). This is because they weren't included in the resolve.alias configuration. Added aliases for all adapter packages (evm, solana, stellar, midnight) to: - resolve.alias - dedupe - optimizeDeps.include - ssr.noExternal This fixes the "Failed to resolve entry for package" error in export tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The export tests were failing in the
update-versions.ymlworkflow with:This was happening because the adapter packages weren't included in the vitest config's
resolve.aliasconfiguration. When Vitest tries to resolve these workspace packages, it needs explicit aliases to find the builtdist/index.jsfiles.Solution
Added aliases for all adapter packages (evm, solana, stellar, midnight) to:
resolve.alias- maps package names to their dist entry pointsdedupe- prevents duplicate package instancesoptimizeDeps.include- pre-bundles for faster testsssr.noExternal- ensures proper handling in test SSR phaseRelated
This fixes the underlying issue that was preventing PR #244 (Version Packages) from succeeding. After merging:
update-versions.ymlworkflow should be able to run the export testsTest plan
update-versionsworkflow onchangeset-release/mainafter merging