-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stacker): Add statusbar animation patterns + enable and handle stallguard #500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, though that's a pretty fast timer
default: | ||
return white_channels; | ||
} | ||
} | ||
|
||
// The timer driving LED update frequency should run at this period | ||
static constexpr uint32_t UPDATE_PERIOD_MS = 1000; | ||
static constexpr uint32_t UPDATE_PERIOD_MS = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that seems like quite a lot, it's the same frequency as the systick. can we make it 10 or something?
auto visit_message(const messages::UpdateUIMessage& m, Policy& policy) | ||
-> void { | ||
static constexpr double TWO = 2.0F; | ||
for (auto bar_id : {StatusBarID::Internal, StatusBarID::External}) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooh fancy i love it
Overview
Now that the Flex Stacker is in ABR and Science, let's enable stallguard and add UI led to some states to inform the user what's happening with the device. This pull request goes in conjunction with this monorepo pull request Opentrons/opentrons#17349
Changelog
SetStatusBarState
gcodesTesting
triggering
estop or stallReview requests