-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hardware): add csv file logging capability to capacitive_probe method #14785
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #14785 +/- ##
===========================================
- Coverage 92.43% 60.15% -32.29%
===========================================
Files 77 189 +112
Lines 1283 10587 +9304
===========================================
+ Hits 1186 6369 +5183
- Misses 97 4218 +4121
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good but definitely some stuff to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Overview
This PR, along with Opentrons/ot3-firmware#768, adds csv file logging capability to the capacitive_probe ot3api method. This work utilizes the work that adds the same capability to the liquid_probe process. The MoveGroupSingleAxisStep, AddSensorLinearMoveRequest, and SendAccumulatedSensorDataRequest classes were modified to include a sensor_type data field. The capacitive_probe_ot3_tunable script was added for testing.
Test Plan
Changelog
Review requests
Risk assessment