test(api): liquid class delay properties enable strict bool and tests #17722
+157
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* edge:
feat(robot-server): Allow storing and retrieving location-nonspecific ("default") offsets (#17704)
refactor(step-generation): split up movableTrashCommandsUtil() into separate functions (#17694)
refactor(api): opentrons driver error handling (#17689)
fix(api, shared-data): Pick up tc lid directly off deck slot fix (#17683)
fix(step-generation): make prevRobotState required in movableTrashCommandsUtil (#17705)
refactor(protocol-designer): account for 96-channel load_instrument syntax & pythonName (#17691)
chore(components): add a new foldere Helix to Storybook (#17699)
fix(protocol-designer, shared-data): update command schema to v10 (#17550)
Revert "feat(step-generation): introduce airGapInPlace command (#17357)"
Revert "fix(step-generation): properly update robotState when dispense is after airGap (#17392)"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17722 +/- ##
==========================================
+ Coverage 21.84% 23.72% +1.88%
==========================================
Files 2822 2835 +13
Lines 217431 218395 +964
Branches 8214 9191 +977
==========================================
+ Hits 47491 51815 +4324
+ Misses 169940 166574 -3366
- Partials 0 6 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
y3rsh
commented
Mar 11, 2025
Comment on lines
+14
to
+69
| # -------------------------------------------------------------------------------------- | ||
| # Strategies | ||
| # -------------------------------------------------------------------------------------- | ||
|
|
||
| invalid_values = st.one_of( | ||
| st.text(min_size=0, max_size=5), | ||
| st.dictionaries(keys=st.text(), values=st.integers()), | ||
| st.lists(st.integers(min_value=-100, max_value=100), min_size=1, max_size=5), | ||
| st.tuples(st.booleans()), | ||
| st.binary(min_size=1, max_size=5), | ||
| ) | ||
|
|
||
| boolean_looking_values = st.one_of( | ||
| st.just("True"), | ||
| st.just("1"), | ||
| st.just(1), | ||
| st.just("False"), | ||
| st.just("0"), | ||
| st.just(0), | ||
| ) | ||
|
|
||
| reasonable_floats = st.floats( | ||
| min_value=-1000, max_value=1000, allow_infinity=False, allow_nan=False | ||
| ) | ||
| reasonable_ints = st.integers(min_value=-1000, max_value=1000) | ||
|
|
||
| negative_or_zero_floats = st.floats( | ||
| min_value=-1000, max_value=0, allow_infinity=False, allow_nan=False | ||
| ) | ||
| negative_or_zero_ints = st.integers(min_value=-1000, max_value=0) | ||
| negative_or_zero_floats_and_ints = st.one_of( | ||
| negative_or_zero_floats, negative_or_zero_ints | ||
| ) | ||
| positive_or_zero_ints = st.integers(min_value=0, max_value=1000) | ||
| positive_or_zero_floats = st.floats( | ||
| min_value=0, max_value=1000, allow_infinity=False, allow_nan=False | ||
| ) | ||
| positive_or_zero_floats_or_ints = st.one_of( | ||
| positive_or_zero_floats, positive_or_zero_ints | ||
| ) | ||
|
|
||
| negative_non_zero_floats = st.floats( | ||
| min_value=-1000, max_value=-0.0001, allow_infinity=False, allow_nan=False | ||
| ) | ||
| negative_non_zero_ints = st.integers(min_value=-1000, max_value=-1) | ||
| negative_non_zero_floats_and_ints = st.one_of( | ||
| negative_non_zero_floats, negative_non_zero_ints | ||
| ) | ||
|
|
||
| positive_non_zero_floats = st.floats( | ||
| min_value=0.0001, max_value=1000, allow_infinity=False, allow_nan=False | ||
| ) | ||
| positive_non_zero_ints = st.integers(min_value=1, max_value=1000) | ||
| positive_non_zero_floats_and_ints = st.one_of( | ||
| positive_non_zero_floats, positive_non_zero_ints | ||
| ) |
There was a problem hiding this comment.
I will move these into a fixture in the next pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add unit tests for the builder and setters on
DelayPropertiesReview Requests
Does the change to
StrictBoolmake sense?Does this raise code coverage at all?
Risk assessment
Low, mostly tests but a small change to the Model for Delay Properties to be StrictBool